[coreboot-gerrit] Patch merged into coreboot/master: e757220 cbfstool: add code to serialize the header using the new xdr functions
gerrit at coreboot.org
gerrit at coreboot.org
Sun Feb 2 23:48:22 CET 2014
the following patch was just integrated into master:
commit e757220cfcb335a200d41cae990a4295e410ab0b
Author: Ronald G. Minnich <rminnich at google.com>
Date: Mon Jan 6 08:38:15 2014 -0800
cbfstool: add code to serialize the header using the new xdr functions
This change adds a header serialization function. Programmers can thus just
set up a header as needed, without worrying about forgetting if and how to
use the [hn]to[hn]* functions.
In the long term, we will work to remove swab.h, i.e. we need to get to the
point where programmers don't have to try to remember [hn]to[nh]* and where
it goes. To date, even the best programmers we have have made an error with
those functions, and those errors have persisted for 6 or 7 years now. It's
very easy to make that mistake.
BUG=None
TEST=Build a peppy image and verify that it's bit for bit the same. All
chromebooks use this code and build and boot correctly.
BRANCH=None
Change-Id: I0f9b8e7cac5f52d0ea330ba948650fa0803aa0d5
Signed-off-by: Ronald G. Minnich <rminnich at google.com>
Reviewed-on: https://chromium-review.googlesource.com/181552
Reviewed-by: Ronald Minnich <rminnich at chromium.org>
Commit-Queue: Ronald Minnich <rminnich at chromium.org>
Tested-by: Ronald Minnich <rminnich at chromium.org>
See http://review.coreboot.org/5100 for details.
-gerrit
More information about the coreboot-gerrit
mailing list