[coreboot-gerrit] New patch to review for coreboot: 8fe57eb lenovo/x60: Unify volume button handling with common code.

Vladimir Serbinenko (phcoder@gmail.com) gerrit at coreboot.org
Sun Feb 2 18:45:15 CET 2014


Vladimir Serbinenko (phcoder at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5099

-gerrit

commit 8fe57eb46d26747d202a77887b735120b375936b
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date:   Sun Feb 2 18:44:42 2014 +0100

    lenovo/x60: Unify volume button handling with common code.
    
    Change-Id: I45fe44a91f9f83a510b204e01dbaff9e8a9696ca
    Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
 src/ec/lenovo/h8/acpi/ec.asl         |  8 ++++++--
 src/mainboard/lenovo/x60/acpi/ec.asl | 23 -----------------------
 2 files changed, 6 insertions(+), 25 deletions(-)

diff --git a/src/ec/lenovo/h8/acpi/ec.asl b/src/ec/lenovo/h8/acpi/ec.asl
index 4b3fb12..75533cc 100644
--- a/src/ec/lenovo/h8/acpi/ec.asl
+++ b/src/ec/lenovo/h8/acpi/ec.asl
@@ -227,7 +227,6 @@ Device(EC)
 	    ^HKEY.RHK (0x18)
        }
 
-#if CONFIG_BOARD_LENOVO_X201
        Method (_Q1C, 0, NotSerialized)
        {
 	    ^HKEY.RHK (0x19)
@@ -237,7 +236,12 @@ Device(EC)
        {
 	    ^HKEY.RHK (0x1A)
        }
-#endif
+
+       /* Mute */
+       Method (_Q1D, 0, NotSerialized)
+       {
+	    ^HKEY.RHK (0x17)
+       }
 
        Device (HKEY)
        {
diff --git a/src/mainboard/lenovo/x60/acpi/ec.asl b/src/mainboard/lenovo/x60/acpi/ec.asl
index fc02199..a92bc4a 100644
--- a/src/mainboard/lenovo/x60/acpi/ec.asl
+++ b/src/mainboard/lenovo/x60/acpi/ec.asl
@@ -20,26 +20,3 @@
  */
 
 #include <ec/lenovo/h8/acpi/ec.asl>
-
-Scope(\_SB.PCI0.LPCB.EC)
-{
-	/* Volume down */
-	Method(_Q1C, 0, NotSerialized)
-	{
-		Trap(SMI_SAVE_CMOS)
-	}
-
-	/* Volume up */
-	Method(_Q1D, 0, NotSerialized)
-	{
-		Trap(SMI_SAVE_CMOS)
-	}
-
-	/* Mute key pressed */
-	Method(_Q1E, 0, NotSerialized)
-	{
-		Trap(SMI_SAVE_CMOS)
-	}
-
-
-}



More information about the coreboot-gerrit mailing list