[coreboot-gerrit] Patch set updated for coreboot: 5d88cd3 asrock/e350m1: Serialize ACPI IDE methods to avoid races.

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Sun Feb 2 01:16:43 CET 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5080

-gerrit

commit 5d88cd31608c1be4b7361164ce15ba1f5565bf84
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Wed Jan 29 22:12:52 2014 +1100

    asrock/e350m1: Serialize ACPI IDE methods to avoid races.
    
    Fix the remark introduced in ACPICA version 20130517 pertaining to
    blocking threads within a methods. If another thread attempts to use the
    method to create the same (named) object twice a race condition will
    occur. ACPICA BZ 909.
    
    Change-Id: I4bb20c9a75d3d7c89f1dbeb526328eface0fdc0c
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/mainboard/asrock/e350m1/acpi/ide.asl | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/mainboard/asrock/e350m1/acpi/ide.asl b/src/mainboard/asrock/e350m1/acpi/ide.asl
index b3aed9c..4071f85 100644
--- a/src/mainboard/asrock/e350m1/acpi/ide.asl
+++ b/src/mainboard/asrock/e350m1/acpi/ide.asl
@@ -77,7 +77,7 @@ Method(GTTM, 1) /* get total time*/
 Device(PRID)
 {
 	Name (_ADR, Zero)
-	Method(_GTM, 0)
+	Method(_GTM, 0, Serialized)
 	{
 		NAME(OTBF, Buffer(20) { /* out buffer */
 			0xFF, 0xFF, 0xFF, 0xFF,
@@ -122,7 +122,7 @@ Device(PRID)
 		Return(OTBF) /* out buffer */
 	}				/* End Method(_GTM) */
 
-	Method(_STM, 3, NotSerialized)
+	Method(_STM, 3, Serialized)
 	{
 		NAME(INBF, Buffer(20) { /* in buffer */
 			0xFF, 0xFF, 0xFF, 0xFF,
@@ -173,7 +173,7 @@ Device(PRID)
 	Device(MST)
 	{
 		Name(_ADR, 0)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
 			Name(CMBF, Buffer(21) {
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
@@ -209,7 +209,7 @@ Device(PRID)
 	Device(SLAV)
 	{
 		Name(_ADR, 1)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
 			Name(CMBF, Buffer(21) {
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,



More information about the coreboot-gerrit mailing list