[coreboot-gerrit] Patch merged into coreboot/master: 2e0cf14 northbridge/amd/pi/northbridge.c: Remove superfluous logic operand
gerrit at coreboot.org
gerrit at coreboot.org
Mon Dec 29 04:06:26 CET 2014
the following patch was just integrated into master:
commit 2e0cf14e144593f8b364f8741f7196d829f3b427
Author: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Date: Sun Dec 28 20:38:32 2014 -0600
northbridge/amd/pi/northbridge.c: Remove superfluous logic operand
The "((1ull << (sizeof(modules) * 8)) - 1)" statement evaluates to
0xffffffff, but there's no need to AND with that value, as 'modules'
is already 32-bit. The '&&' is most likely a typo, which meant bitwise
and, as indicated by the structure of thus operation.
Remove this superfluous statement. This also fixes a clang warning.
Change-Id: Ie55bd9f8b0ec5fd41e440f56dcedd40c830bf826
Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Reviewed-on: http://review.coreboot.org/7965
Reviewed-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Tested-by: build bot (Jenkins)
See http://review.coreboot.org/7965 for details.
-gerrit
More information about the coreboot-gerrit
mailing list