[coreboot-gerrit] Patch set updated for coreboot: 5dde06f src: Strip out some commented out includes
Stefan Reinauer (stefan.reinauer@coreboot.org)
gerrit at coreboot.org
Fri Dec 19 19:20:28 CET 2014
Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7430
-gerrit
commit 5dde06f58c732cecb76ac1ce265e303a3a5e6d86
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date: Tue Nov 11 16:40:16 2014 +1100
src: Strip out some commented out includes
Change-Id: I5902eb6a606454213e7a7ebfd3985ff22f8c7c91
Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
src/northbridge/amd/amdfam10/raminit_amdmct.c | 1 -
src/soc/nvidia/tegra124/displayhack.c | 1 -
src/southbridge/amd/cimx/sb700/smbus.h | 1 -
src/southbridge/amd/cimx/sb800/smbus.h | 1 -
src/southbridge/amd/cimx/sb900/smbus.h | 1 -
src/southbridge/amd/cs5535/smbus.h | 1 -
src/southbridge/amd/sb800/smbus.h | 1 -
src/southbridge/intel/sch/smihandler.c | 1 -
src/vendorcode/amd/agesa/f12/Porting.h | 1 -
.../amd/agesa/f12/Proc/CPU/Family/0x12/cpuF12PowerMgmtSystemTables.c | 1 -
src/vendorcode/amd/agesa/f12/Proc/GNB/Gfx/GfxGmcInit.c | 1 -
src/vendorcode/amd/agesa/f12/Proc/GNB/Gfx/GfxStrapsInit.c | 1 -
src/vendorcode/amd/agesa/f12/Proc/GNB/Nb/Family/LN/F12NbSmu.c | 1 -
src/vendorcode/amd/agesa/f14/Legacy/Proc/hobTransfer.c | 1 -
src/vendorcode/amd/agesa/f14/Porting.h | 1 -
src/vendorcode/amd/agesa/f14/Proc/Common/AmdInitEarly.c | 1 -
src/vendorcode/amd/agesa/f14/Proc/GNB/Gfx/GfxGmcInit.c | 2 --
src/vendorcode/amd/agesa/f14/Proc/GNB/Gfx/GfxStrapsInit.c | 1 -
src/vendorcode/amd/agesa/f14/Proc/GNB/PCIe/Family/0x14/F14PcieAlib.c | 1 -
src/vendorcode/amd/agesa/f15/Porting.h | 1 -
src/vendorcode/amd/agesa/f15tn/Porting.h | 2 --
src/vendorcode/amd/agesa/f16kb/Porting.h | 2 --
22 files changed, 25 deletions(-)
diff --git a/src/northbridge/amd/amdfam10/raminit_amdmct.c b/src/northbridge/amd/amdfam10/raminit_amdmct.c
index e5c18a8..51f10f3 100644
--- a/src/northbridge/amd/amdfam10/raminit_amdmct.c
+++ b/src/northbridge/amd/amdfam10/raminit_amdmct.c
@@ -115,7 +115,6 @@ static void print_t(const char *strval)
#include "../amdmct/mct/mctardk4.c"
//#elif SYSTEM_TYPE == MOBILE
//s1g1
-//#include "../amdmct/mct/mctardk5.c"
#endif
#endif /* DDR2 */
diff --git a/src/soc/nvidia/tegra124/displayhack.c b/src/soc/nvidia/tegra124/displayhack.c
index af0ac16..d1ee971 100644
--- a/src/soc/nvidia/tegra124/displayhack.c
+++ b/src/soc/nvidia/tegra124/displayhack.c
@@ -38,7 +38,6 @@
#include "sor.h"
#include <soc/display.h>
-//#include <soc/nvidia/tegra/displayport.h>
extern int dump;
unsigned long READL(void *p);
void WRITEL(unsigned long value, void *p);
diff --git a/src/southbridge/amd/cimx/sb700/smbus.h b/src/southbridge/amd/cimx/sb700/smbus.h
index 819c2f2..dcc77eb 100644
--- a/src/southbridge/amd/cimx/sb700/smbus.h
+++ b/src/southbridge/amd/cimx/sb700/smbus.h
@@ -20,7 +20,6 @@
#ifndef _SB700_SMBUS_H_
#define _SB700_SMBUS_H_
-//#include <stdint.h>
#include <Platform.h> /* SMBUS0_BASE_ADDRESS */
#ifndef SMBUS0_BASE_ADDRESS
#error SMBUS0_BASE_ADDRESS not define
diff --git a/src/southbridge/amd/cimx/sb800/smbus.h b/src/southbridge/amd/cimx/sb800/smbus.h
index 398c086..ad478dd 100644
--- a/src/southbridge/amd/cimx/sb800/smbus.h
+++ b/src/southbridge/amd/cimx/sb800/smbus.h
@@ -20,7 +20,6 @@
#ifndef _SB800_SMBUS_H_
#define _SB800_SMBUS_H_
-//#include <stdint.h>
#define SMBUS_IO_BASE SMBUS0_BASE_ADDRESS
diff --git a/src/southbridge/amd/cimx/sb900/smbus.h b/src/southbridge/amd/cimx/sb900/smbus.h
index 070b764..5f9b7df 100644
--- a/src/southbridge/amd/cimx/sb900/smbus.h
+++ b/src/southbridge/amd/cimx/sb900/smbus.h
@@ -20,7 +20,6 @@
#ifndef _SB900_SMBUS_H_
#define _SB900_SMBUS_H_
-//#include <stdint.h>
#define SMBUS_IO_BASE SMBUS0_BASE_ADDRESS
diff --git a/src/southbridge/amd/cs5535/smbus.h b/src/southbridge/amd/cs5535/smbus.h
index db35f6e..a153c5a 100644
--- a/src/southbridge/amd/cs5535/smbus.h
+++ b/src/southbridge/amd/cs5535/smbus.h
@@ -1,4 +1,3 @@
-//#include <device/smbus_def.h>
#define SMBUS_ERROR -1
#define SMBUS_WAIT_UNTIL_READY_TIMEOUT -2
#define SMBUS_WAIT_UNTIL_DONE_TIMEOUT -3
diff --git a/src/southbridge/amd/sb800/smbus.h b/src/southbridge/amd/sb800/smbus.h
index 22cdad9..615935a 100644
--- a/src/southbridge/amd/sb800/smbus.h
+++ b/src/southbridge/amd/sb800/smbus.h
@@ -20,7 +20,6 @@
#ifndef SB800_SMBUS_H
#define SB800_SMBUS_H
-//#include <stdint.h>
#define SMBHSTSTAT 0x0
#define SMBSLVSTAT 0x1
diff --git a/src/southbridge/intel/sch/smihandler.c b/src/southbridge/intel/sch/smihandler.c
index 5074138..b36c079 100644
--- a/src/southbridge/intel/sch/smihandler.c
+++ b/src/southbridge/intel/sch/smihandler.c
@@ -70,7 +70,6 @@
#define SS_CNT 0x50
#define C3_RES 0x54
-//#include "i82801gx_nvs.h"
/* While we read PMBASE dynamically in case it changed, let's
* initialize it with a sane value
diff --git a/src/vendorcode/amd/agesa/f12/Porting.h b/src/vendorcode/amd/agesa/f12/Porting.h
index 2eba9f4..25c7bb6 100644
--- a/src/vendorcode/amd/agesa/f12/Porting.h
+++ b/src/vendorcode/amd/agesa/f12/Porting.h
@@ -62,7 +62,6 @@
#define RDATA_GROUP(arg) __pragma (const_seg (MAKE_AS_A_STRING (.d##arg)))
#define FUNC_ATTRIBUTE(arg) __declspec(arg)
- //#include <intrin.h> // MS has built-in functions
#if _MSC_VER < 900
// -----------------------------------------------------------------------
diff --git a/src/vendorcode/amd/agesa/f12/Proc/CPU/Family/0x12/cpuF12PowerMgmtSystemTables.c b/src/vendorcode/amd/agesa/f12/Proc/CPU/Family/0x12/cpuF12PowerMgmtSystemTables.c
index 3ca62c2..8a2b13c 100644
--- a/src/vendorcode/amd/agesa/f12/Proc/CPU/Family/0x12/cpuF12PowerMgmtSystemTables.c
+++ b/src/vendorcode/amd/agesa/f12/Proc/CPU/Family/0x12/cpuF12PowerMgmtSystemTables.c
@@ -49,7 +49,6 @@
#include "cpuRegisters.h"
#include "cpuApicUtilities.h"
#include "cpuFamilyTranslation.h"
-//#include "IdsF12AllService.h"
#include "cpuPowerMgmtSystemTables.h"
#include "cpuF12SoftwareThermal.h"
#include "cpuF12PowerPlane.h"
diff --git a/src/vendorcode/amd/agesa/f12/Proc/GNB/Gfx/GfxGmcInit.c b/src/vendorcode/amd/agesa/f12/Proc/GNB/Gfx/GfxGmcInit.c
index 5c5ab45..98dfdf8 100644
--- a/src/vendorcode/amd/agesa/f12/Proc/GNB/Gfx/GfxGmcInit.c
+++ b/src/vendorcode/amd/agesa/f12/Proc/GNB/Gfx/GfxGmcInit.c
@@ -49,7 +49,6 @@
#include "AGESA.h"
#include "amdlib.h"
#include "Ids.h"
-//#include "heapManager.h"
#include "Gnb.h"
#include "GnbGfx.h"
#include "GnbPcie.h"
diff --git a/src/vendorcode/amd/agesa/f12/Proc/GNB/Gfx/GfxStrapsInit.c b/src/vendorcode/amd/agesa/f12/Proc/GNB/Gfx/GfxStrapsInit.c
index c78c7bd..5c3a259 100644
--- a/src/vendorcode/amd/agesa/f12/Proc/GNB/Gfx/GfxStrapsInit.c
+++ b/src/vendorcode/amd/agesa/f12/Proc/GNB/Gfx/GfxStrapsInit.c
@@ -50,7 +50,6 @@
#include "AGESA.h"
#include "amdlib.h"
#include "Ids.h"
-//#include "heapManager.h"
#include "Gnb.h"
#include "GnbGfx.h"
#include "GnbCommonLib.h"
diff --git a/src/vendorcode/amd/agesa/f12/Proc/GNB/Nb/Family/LN/F12NbSmu.c b/src/vendorcode/amd/agesa/f12/Proc/GNB/Nb/Family/LN/F12NbSmu.c
index 934c7dc..e308b44 100644
--- a/src/vendorcode/amd/agesa/f12/Proc/GNB/Nb/Family/LN/F12NbSmu.c
+++ b/src/vendorcode/amd/agesa/f12/Proc/GNB/Nb/Family/LN/F12NbSmu.c
@@ -50,7 +50,6 @@
#include "AGESA.h"
#include "amdlib.h"
#include "Ids.h"
-//#include "heapManager.h"
#include "Gnb.h"
#include "NbSmuLib.h"
#include "F12NbSmuFirmware.h"
diff --git a/src/vendorcode/amd/agesa/f14/Legacy/Proc/hobTransfer.c b/src/vendorcode/amd/agesa/f14/Legacy/Proc/hobTransfer.c
index 32b5fb4..1ace1ae 100644
--- a/src/vendorcode/amd/agesa/f14/Legacy/Proc/hobTransfer.c
+++ b/src/vendorcode/amd/agesa/f14/Legacy/Proc/hobTransfer.c
@@ -58,7 +58,6 @@
#include "cpuCacheInit.h"
#include "cpuFamilyTranslation.h"
#include "heapManager.h"
-//#include "cpuLateInit.h"
#include "cpuEnvInit.h"
#include "Filecode.h"
CODE_GROUP (G1_PEICC)
diff --git a/src/vendorcode/amd/agesa/f14/Porting.h b/src/vendorcode/amd/agesa/f14/Porting.h
index 786ec66..166e616 100644
--- a/src/vendorcode/amd/agesa/f14/Porting.h
+++ b/src/vendorcode/amd/agesa/f14/Porting.h
@@ -62,7 +62,6 @@
#define RDATA_GROUP(arg) __pragma (const_seg (MAKE_AS_A_STRING (.d##arg)))
#define FUNC_ATTRIBUTE(arg) __declspec(arg)
- //#include <intrin.h> // MS has built-in functions
#if _MSC_VER < 900
// -----------------------------------------------------------------------
diff --git a/src/vendorcode/amd/agesa/f14/Proc/Common/AmdInitEarly.c b/src/vendorcode/amd/agesa/f14/Proc/Common/AmdInitEarly.c
index 5709a49..bdaf9ca 100644
--- a/src/vendorcode/amd/agesa/f14/Proc/Common/AmdInitEarly.c
+++ b/src/vendorcode/amd/agesa/f14/Proc/Common/AmdInitEarly.c
@@ -60,7 +60,6 @@
#include "cpuServices.h"
#include "CommonInits.h"
#include "GnbInterface.h"
-//#include "GnbInitAtEarly.h"
#include "Filecode.h"
CODE_GROUP (G1_PEICC)
RDATA_GROUP (G1_PEICC)
diff --git a/src/vendorcode/amd/agesa/f14/Proc/GNB/Gfx/GfxGmcInit.c b/src/vendorcode/amd/agesa/f14/Proc/GNB/Gfx/GfxGmcInit.c
index 7929d02..8a0d15a 100644
--- a/src/vendorcode/amd/agesa/f14/Proc/GNB/Gfx/GfxGmcInit.c
+++ b/src/vendorcode/amd/agesa/f14/Proc/GNB/Gfx/GfxGmcInit.c
@@ -50,7 +50,6 @@
#include "AGESA.h"
#include "amdlib.h"
#include "Ids.h"
-//#include "heapManager.h"
#include "Gnb.h"
#include "GnbGfx.h"
#include "GnbPcie.h"
@@ -59,7 +58,6 @@
#include "GfxLib.h"
#include "GfxFamilyServices.h"
#include "GfxRegisterAcc.h"
-//#include "GfxStrapsInit.h"
#include "OptionGnb.h"
#include "GnbRegistersON.h"
#include "Filecode.h"
diff --git a/src/vendorcode/amd/agesa/f14/Proc/GNB/Gfx/GfxStrapsInit.c b/src/vendorcode/amd/agesa/f14/Proc/GNB/Gfx/GfxStrapsInit.c
index 1c7a860..41db48b 100644
--- a/src/vendorcode/amd/agesa/f14/Proc/GNB/Gfx/GfxStrapsInit.c
+++ b/src/vendorcode/amd/agesa/f14/Proc/GNB/Gfx/GfxStrapsInit.c
@@ -51,7 +51,6 @@
#include "AGESA.h"
#include "amdlib.h"
#include "Ids.h"
-//#include "heapManager.h"
#include "Gnb.h"
#include "GnbGfx.h"
#include GNB_MODULE_DEFINITIONS (GnbCommonLib)
diff --git a/src/vendorcode/amd/agesa/f14/Proc/GNB/PCIe/Family/0x14/F14PcieAlib.c b/src/vendorcode/amd/agesa/f14/Proc/GNB/PCIe/Family/0x14/F14PcieAlib.c
index 066bcf8..71c7ccc 100644
--- a/src/vendorcode/amd/agesa/f14/Proc/GNB/PCIe/Family/0x14/F14PcieAlib.c
+++ b/src/vendorcode/amd/agesa/f14/Proc/GNB/PCIe/Family/0x14/F14PcieAlib.c
@@ -52,7 +52,6 @@
#include "Ids.h"
#include "heapManager.h"
#include "Gnb.h"
-//#include "GnbPcieFamServices.h"
#include "GnbFuseTable.h"
#include "GnbRegistersON.h"
#include "cpuLateInit.h"
diff --git a/src/vendorcode/amd/agesa/f15/Porting.h b/src/vendorcode/amd/agesa/f15/Porting.h
index 776cddc..c79eca0 100644
--- a/src/vendorcode/amd/agesa/f15/Porting.h
+++ b/src/vendorcode/amd/agesa/f15/Porting.h
@@ -60,7 +60,6 @@
#define RDATA_GROUP(arg) __pragma (const_seg (MAKE_AS_A_STRING (.d##arg)))
- //#include <intrin.h> // MS has built-in functions
#if _MSC_VER < 900
// -----------------------------------------------------------------------
diff --git a/src/vendorcode/amd/agesa/f15tn/Porting.h b/src/vendorcode/amd/agesa/f15tn/Porting.h
index fc65cfc..cc6e943 100644
--- a/src/vendorcode/amd/agesa/f15tn/Porting.h
+++ b/src/vendorcode/amd/agesa/f15tn/Porting.h
@@ -59,7 +59,6 @@
#define RDATA_GROUP(arg) __pragma (const_seg (MAKE_AS_A_STRING (.d##arg)))
#define FUNC_ATTRIBUTE(arg) __declspec(arg)
- //#include <intrin.h> // MS has built-in functions
#if _MSC_VER < 900
// -----------------------------------------------------------------------
@@ -242,7 +241,6 @@
typedef void VOID;
//typedef unsigned long size_t;
- //#include <intrin.h> // MingW-w64 library header
#pragma pack(1)
#define CODE_GROUP(arg)
diff --git a/src/vendorcode/amd/agesa/f16kb/Porting.h b/src/vendorcode/amd/agesa/f16kb/Porting.h
index da78fb8..f3b6462 100644
--- a/src/vendorcode/amd/agesa/f16kb/Porting.h
+++ b/src/vendorcode/amd/agesa/f16kb/Porting.h
@@ -59,7 +59,6 @@
#define RDATA_GROUP(arg) __pragma (const_seg (MAKE_AS_A_STRING (.d##arg)))
#define FUNC_ATTRIBUTE(arg) __declspec(arg)
- //#include <intrin.h> // MS has built-in functions
#if _MSC_VER < 900
// -----------------------------------------------------------------------
@@ -242,7 +241,6 @@
typedef void VOID;
//typedef unsigned long size_t;
- //#include <intrin.h> // MingW-w64 library header
#pragma pack(1)
#define CODE_GROUP(arg)
More information about the coreboot-gerrit
mailing list