[coreboot-gerrit] Patch merged into coreboot/master: cb0dd58 amd/agesa/f*/Lib/amdlib.c: Integer overflow in loop construct

gerrit at coreboot.org gerrit at coreboot.org
Tue Dec 16 17:21:45 CET 2014


the following patch was just integrated into master:
commit cb0dd58b37b22f7731cd81da8024934040fafdc0
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Sun Dec 7 05:20:14 2014 +1100

    amd/agesa/f*/Lib/amdlib.c: Integer overflow in loop construct
    
    As is the case in commit:
    
     3312ed7 amd/agesa/f1?/Lib/amdlib.c: Integer overflow in loop construct
    
    The semantics of this loop relies on an integer overflow in Index >=0
    that implies a return value of (UINT8)-1 which around wraps to 0xFF, or
    VOLT_UNSUPPORTED.
    
    Also fix an infinite loop.
    
    Change-Id: Iced3eff3ae7b8935db3bdd6147372cf3b540883c
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
    Reviewed-on: http://review.coreboot.org/7676
    Reviewed-by: Bruce Griffith <Bruce.Griffith at se-eng.com>
    Tested-by: build bot (Jenkins)
    Reviewed-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>


See http://review.coreboot.org/7676 for details.

-gerrit



More information about the coreboot-gerrit mailing list