[coreboot-gerrit] Patch merged into coreboot/master: cdb61a6 i2c: Replace the i2c API.

gerrit at coreboot.org gerrit at coreboot.org
Tue Dec 16 00:02:46 CET 2014


the following patch was just integrated into master:
commit cdb61a6f5d2268b059ac56da3b69ad0313f3fb90
Author: Gabe Black <gabeblack at google.com>
Date:   Mon Apr 7 18:45:14 2014 -0700

    i2c: Replace the i2c API.
    
    The new API is in use in depthcharge and is based around the "i2c_transfer"
    function instead of i2c_read and i2c_write. The new function takes an array of
    i2c_seg structures which represent each portion of the transfer after a start
    bit and before the stop bit. If there's more than one segment, they're
    seperated by repeated starts.
    
    Some wrapper functions have also been added which make certain common
    operations easy. These include reading or writing a byte from a register or
    reading or writing a blob of raw data. The i2c device drivers generally use
    these wrappers but can call the i2c_transfer function directly if the need
    something different.
    
    The tegra i2c driver was very similar to the one in depthcharge and was simple
    to convert. The Exynos 5250 and 5420 drivers were ported from depthcharge and
    replace the ones in coreboot. The Exynos 5420 driver was ported from the high
    speed portion of the one in coreboot and was straightforward to port back. The
    low speed portion and the Exynos 5250 drivers had been transplanted from U-Boot
    and were replaced with the depthcharge implementation.
    
    BUG=None
    TEST=Built and booted on nyan with and without EFS. Built and booted on, pit
    and daisy.
    BRANCH=None
    
    Original-Change-Id: I1e98c3fa2560be25444ab3d0394bb214b9d56e93
    Original-Signed-off-by: Gabe Black <gabeblack at google.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/193561
    Original-Reviewed-by: David Hendricks <dhendrix at chromium.org>
    Original-Reviewed-by: Jimmy Zhang <jimmzhang at nvidia.com>
    Original-Tested-by: Jimmy Zhang <jimmzhang at nvidia.com>
    Original-Reviewed-by: Hung-Te Lin <hungte at chromium.org>
    Original-Commit-Queue: Gabe Black <gabeblack at chromium.org>
    Original-Tested-by: Gabe Black <gabeblack at chromium.org>
    (cherry picked from commit 00c423fb2c06c69d580ee3ec0a3892ebf164a5fe)
    
    This cherry-pick required additional changes to the following:
    src/cpu/allwinner/a10/twi.c
    src/drivers/xpowers/axp209/axp209.c
    
    Signed-off-by: Marc Jones <marc.jones at se-eng.com>
    
    Change-Id: I691959c66308eeeec219b1bec463b8b365a246d7
    Reviewed-on: http://review.coreboot.org/7751
    Tested-by: build bot (Jenkins)
    Reviewed-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
    Reviewed-by: Patrick Georgi <pgeorgi at google.com>


See http://review.coreboot.org/7751 for details.

-gerrit



More information about the coreboot-gerrit mailing list