[coreboot-gerrit] Patch merged into coreboot/master: 638015b arm: Fix minor mistake in cache maintenance assembly

gerrit at coreboot.org gerrit at coreboot.org
Mon Dec 15 23:27:43 CET 2014


the following patch was just integrated into master:
commit 638015b98b918655fde3ca46cf437c44bd49039f
Author: Julius Werner <jwerner at chromium.org>
Date:   Fri Apr 4 14:01:15 2014 -0700

    arm: Fix minor mistake in cache maintenance assembly
    
    Turns out that when you clear 28 bits starting with bit 3, you leave bit
    31 standing. Ooops...
    
    This shouldn't really matter since that bit is reserved/SBZ in CLIDR
    anyway, but it's still nice to fix it. This whole thing should really be
    an AND for clarity anyway in my opinion.
    
    Bug found in upstream NetBSD (who would've thought...).
    
    BUG=None
    TEST=Still boots.
    
    Change-Id: Ic826e82d58fd1ce984971afea3dfa9296f746d9f
    Signed-off-by: Julius Werner <jwerner at chromium.org>
    Reviewed-on: https://chromium-review.googlesource.com/193300
    Reviewed-by: David Hendricks <dhendrix at chromium.org>
    Reviewed-by: Gabe Black <gabeblack at chromium.org>
    (cherry picked from commit d270c0ec18b74b272451c456cbf07e99d95896cb)
    Signed-off-by: Marc Jones <marc.jones at se-eng.com>
    Reviewed-on: http://review.coreboot.org/7745
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/7745 for details.

-gerrit



More information about the coreboot-gerrit mailing list