[coreboot-gerrit] Patch set updated for coreboot: 6d3229b vendorcode/amd/agesa/f16kb/*/PcieComplexDataKB.c: Implicit truncation

[Edward O'Callaghan (eocallaghan@alterapraxis.com)]

Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7719

-gerrit

commit 6d3229b8bde23b021d55a9a2f1952b4694f8eb85
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Tue Dec 9 03:39:13 2014 +1100

    vendorcode/amd/agesa/f16kb/*/PcieComplexDataKB.c: Implicit truncation
    
    Clang complains:
     "implicit truncation from 'int' to bitfield changes value from -1 to 15"
    
    -1 is define in 'c11std 6.3.1.3p2' as:
    
     [Signed and unsigned integers] Otherwise, if the new type is unsigned,
     the value is converted by repeatedly adding or subtracting one
     more than the maximum value that can be represented in the new type
     until the value is in the range of the new type.60)
     FOOTNOTE.60 The rules describe arithmetic on the mathem...
    
    This is "0xFF" on Mullins and "0xF" in this case. Clang seems to
    complain about this two's complement in a bitfield as being truncated.
    As the bitfield is 4 bits wide, (a maximum of 15 decimal), we set the
    field as '0x0F'. Ideally this field /should/ be set to 'UINT8_MAX' however
    we still have silly truncation warnings.
    
    Change-Id: Ib7476d453ffd932bb911e638117cf9f56f71f269
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 .../amd/agesa/f16kb/Proc/GNB/Modules/GnbInitKB/PcieComplexDataKB.c    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/vendorcode/amd/agesa/f16kb/Proc/GNB/Modules/GnbInitKB/PcieComplexDataKB.c b/src/vendorcode/amd/agesa/f16kb/Proc/GNB/Modules/GnbInitKB/PcieComplexDataKB.c
index 5fd3cca..8630312 100644
--- a/src/vendorcode/amd/agesa/f16kb/Proc/GNB/Modules/GnbInitKB/PcieComplexDataKB.c
+++ b/src/vendorcode/amd/agesa/f16kb/Proc/GNB/Modules/GnbInitKB/PcieComplexDataKB.c
@@ -145,8 +145,8 @@ KB_COMPLEX_CONFIG ComplexDataKB = {
     0,
     DDI_START_PHY_LANE,
     DDI_END_PHY_LANE,
-    -1,
-    0,
+    0x0F, // Start PCIe Core ID (4 bits) - Should be 'UINT8_MAX' however clang complains of truncation
+    0,    // End PCIe Core ID   (4 bits)
     0,
     {
       1,