[coreboot-gerrit] New patch to review for coreboot: 5494856 nehalem/raminit: Add decorations to specify that empty loop is intended so.

Vladimir Serbinenko (phcoder@gmail.com) gerrit at coreboot.org
Sun Dec 7 13:10:41 CET 2014


Vladimir Serbinenko (phcoder at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7683

-gerrit

commit 5494856ad3f35419cc7db2634fbe321d60230b44
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date:   Sun Dec 7 13:05:44 2014 +0100

    nehalem/raminit: Add decorations to specify that empty loop is intended so.
    
    Change-Id: I6a05683daa6105e26017d1abf45881a9ef93ea30
    Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
 src/northbridge/intel/nehalem/raminit.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/northbridge/intel/nehalem/raminit.c b/src/northbridge/intel/nehalem/raminit.c
index fb82484..9ca98d5 100644
--- a/src/northbridge/intel/nehalem/raminit.c
+++ b/src/northbridge/intel/nehalem/raminit.c
@@ -4571,7 +4571,9 @@ void raminit(const int s3resume, const u8 *spd_addrmap)
 	write_mchbar32(0x140, read_mchbar32(0x140) & ~0x07000000);
 	write_mchbar32(0x138, read_mchbar32(0x138) & ~0x07000000);
 	write_mchbar32(0x130, 0x31111301);
-	while (read_mchbar32(0x130) & 1) ;
+	/* Wait until REG130b0 is 1.  */
+	while (read_mchbar32(0x130) & 1)
+		;
 
 	{
 		u32 t;



More information about the coreboot-gerrit mailing list