[coreboot-gerrit] Patch set updated for coreboot: 3b26c10 AMD Hudson boards: Hide HUDSON_LEGACY_FREE prompts.

[Edward O'Callaghan (eocallaghan@alterapraxis.com)]

Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7358

-gerrit

commit 3b26c1058174f4a06d32d81a6d16fc611d10d5c6
Author: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
Date:   Sat Nov 8 17:00:53 2014 +0100

    AMD Hudson boards: Hide HUDSON_LEGACY_FREE prompts.
    
    The legacy free property depends on the board design and shouldn't be
    user-selectable. Any legacy keyboard, serial or other controller enabled
    on FCH or SuperIO invalidates the legacy free setting.
    
    In particular, if a serial port is present and used for debugging, setting
    HUDSON_LEGACY_FREE will cause AGESA to disable FCH/LPC I/O decode of the
    serial port and prevent many early boot messages from being logged to the
    serial port.
    
    Change-Id: Ibc9297d75917a2dd4e056e554b10c0e86877d3ed
    Signed-off-by: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
---
 src/mainboard/amd/olivehill/Kconfig      | 5 +----
 src/mainboard/amd/olivehillplus/Kconfig  | 5 +----
 src/mainboard/amd/parmer/Kconfig         | 5 +----
 src/mainboard/amd/thatcher/Kconfig       | 5 +----
 src/mainboard/asrock/imb-a180/Kconfig    | 4 ----
 src/southbridge/amd/agesa/hudson/Kconfig | 3 ++-
 6 files changed, 6 insertions(+), 21 deletions(-)

diff --git a/src/mainboard/amd/olivehill/Kconfig b/src/mainboard/amd/olivehill/Kconfig
index ea97550..52bd836 100644
--- a/src/mainboard/amd/olivehill/Kconfig
+++ b/src/mainboard/amd/olivehill/Kconfig
@@ -31,6 +31,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select HAVE_ACPI_TABLES
 	select BOARD_ROMSIZE_KB_4096
 	select GFXUMA
+	select HUDSON_LEGACY_FREE
 
 config MAINBOARD_DIR
 	string
@@ -64,8 +65,4 @@ config ONBOARD_VGA_IS_PRIMARY
 	bool
 	default y
 
-config HUDSON_LEGACY_FREE
-	bool
-	default y
-
 endif # BOARD_AMD_OLIVEHILL
diff --git a/src/mainboard/amd/olivehillplus/Kconfig b/src/mainboard/amd/olivehillplus/Kconfig
index 93f0fc6..ab32f7b 100644
--- a/src/mainboard/amd/olivehillplus/Kconfig
+++ b/src/mainboard/amd/olivehillplus/Kconfig
@@ -31,6 +31,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select HAVE_ACPI_TABLES
 	select BOARD_ROMSIZE_KB_8192
 	select GFXUMA
+	select HUDSON_LEGACY_FREE
 
 config MAINBOARD_DIR
 	string
@@ -64,8 +65,4 @@ config ONBOARD_VGA_IS_PRIMARY
 	bool
 	default y
 
-config HUDSON_LEGACY_FREE
-	bool
-	default y
-
 endif # BOARD_AMD_OLIVEHILLPLUS
diff --git a/src/mainboard/amd/parmer/Kconfig b/src/mainboard/amd/parmer/Kconfig
index ff198a6..2e9bebd 100644
--- a/src/mainboard/amd/parmer/Kconfig
+++ b/src/mainboard/amd/parmer/Kconfig
@@ -32,6 +32,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select BOARD_ROMSIZE_KB_4096
 	select GFXUMA
 	select UDELAY_LAPIC
+	select HUDSON_LEGACY_FREE
 
 config MAINBOARD_DIR
 	string
@@ -65,8 +66,4 @@ config VGA_BIOS_ID
 	string
 	default "1002,9900"
 
-config HUDSON_LEGACY_FREE
-	bool
-	default y
-
 endif # BOARD_AMD_PARMER
diff --git a/src/mainboard/amd/thatcher/Kconfig b/src/mainboard/amd/thatcher/Kconfig
index c228365..c6de0fe 100644
--- a/src/mainboard/amd/thatcher/Kconfig
+++ b/src/mainboard/amd/thatcher/Kconfig
@@ -32,6 +32,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select SUPERIO_SMSC_LPC47N217
 	select BOARD_ROMSIZE_KB_4096
 	select GFXUMA
+	select HUDSON_LEGACY_FREE
 
 config MAINBOARD_DIR
 	string
@@ -65,8 +66,4 @@ config VGA_BIOS_ID
 	string
 	default "1002,9917"
 
-config HUDSON_LEGACY_FREE
-	bool
-	default y
-
 endif # BOARD_AMD_THATCHER
diff --git a/src/mainboard/asrock/imb-a180/Kconfig b/src/mainboard/asrock/imb-a180/Kconfig
index f3c8aa7..6cfb48f 100644
--- a/src/mainboard/asrock/imb-a180/Kconfig
+++ b/src/mainboard/asrock/imb-a180/Kconfig
@@ -65,10 +65,6 @@ config ONBOARD_VGA_IS_PRIMARY
 	bool
 	default y
 
-config HUDSON_LEGACY_FREE
-	bool
-	default y
-
 # bit 1,0 - pin 0
 # bit 3,2 - pin 1
 # bit 5,4 - pin 2
diff --git a/src/southbridge/amd/agesa/hudson/Kconfig b/src/southbridge/amd/agesa/hudson/Kconfig
index 72370ea..ffedd95 100644
--- a/src/southbridge/amd/agesa/hudson/Kconfig
+++ b/src/southbridge/amd/agesa/hudson/Kconfig
@@ -201,7 +201,8 @@ endif
 config HUDSON_LEGACY_FREE
 	bool "System is legacy free"
 	help
-	  Select y if there is no keyboard controller in the system.
+	  Select y if there is no keyboard, serial or other legacy controllers
+	  enabled in the system, on both the FCH and any LPC SuperIO or EC.
 	  This sets variables in AGESA and ACPI.
 
 config ACPI_ENABLE_THERMAL_ZONE