[coreboot-gerrit] Patch merged into coreboot/master: e890531 nvramtool: cmos_read(): Use malloc() instead of alloca()

gerrit at coreboot.org gerrit at coreboot.org
Tue Dec 2 10:15:02 CET 2014


the following patch was just integrated into master:
commit e8905312f066fc899089edebe803873819f2b920
Author: Andrew Engelbrecht <sudoman at ninthfloor.org>
Date:   Mon Dec 1 12:22:48 2014 -0500

    nvramtool: cmos_read(): Use malloc() instead of alloca()
    
    Fixes crash occurring when 'nvramtool -a' tried to free a prematurely
    freed pointer. (Tested on x60)
    
    malloc() is correct because the pointer is accessed outside the calling
    function. The pointer is freed in the parent function list_cmos_entry().
    
    Change-Id: I1723f09740657f0f0d9e6954bd6d11c0a3820a42
    Signed-off-by: Andrew Engelbrecht <sudoman at ninthfloor.org>
    Reviewed-on: http://review.coreboot.org/7620
    Tested-by: build bot (Jenkins)
    Reviewed-by: Patrick Georgi <pgeorgi at google.com>
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>


See http://review.coreboot.org/7620 for details.

-gerrit



More information about the coreboot-gerrit mailing list