[coreboot-gerrit] Patch set updated for coreboot: 3e8628d roda/rk886ex: Move device changes to mainboard code from acpi tables code

Vladimir Serbinenko (phcoder@gmail.com) gerrit at coreboot.org
Sun Aug 31 02:03:35 CEST 2014


Vladimir Serbinenko (phcoder at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6807

-gerrit

commit 3e8628d671da1f262efb8d027b6fe4d491de87b7
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date:   Sun Aug 31 00:30:26 2014 +0200

    roda/rk886ex: Move device changes to mainboard code from acpi tables code
    
    Change-Id: I3d694e5b3092d78bce89f6baa7b2dedffddf3012
    Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
 src/mainboard/roda/rk886ex/acpi_tables.c | 4 ----
 src/mainboard/roda/rk886ex/mainboard.c   | 3 +++
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/mainboard/roda/rk886ex/acpi_tables.c b/src/mainboard/roda/rk886ex/acpi_tables.c
index f6ed4ae..c81c2f6 100644
--- a/src/mainboard/roda/rk886ex/acpi_tables.c
+++ b/src/mainboard/roda/rk886ex/acpi_tables.c
@@ -263,9 +263,5 @@ unsigned long write_acpi_tables(unsigned long start)
 	printk(BIOS_DEBUG, "current = %lx\n", current);
 	printk(BIOS_INFO, "ACPI: done.\n");
 
-	/* Enable Dummy DCC ON# for DVI */
-	printk(BIOS_DEBUG, "Laptop handling...\n");
-	outb(inb(0x60f) & ~(1 << 5), 0x60f);
-
 	return current;
 }
diff --git a/src/mainboard/roda/rk886ex/mainboard.c b/src/mainboard/roda/rk886ex/mainboard.c
index 7f188d4..7158dca 100644
--- a/src/mainboard/roda/rk886ex/mainboard.c
+++ b/src/mainboard/roda/rk886ex/mainboard.c
@@ -131,6 +131,9 @@ static void mainboard_enable(device_t dev)
 #if DUMP_RUNTIME_REGISTERS
 	dump_runtime_registers();
 #endif
+	/* Enable Dummy DCC ON# for DVI */
+	printk(BIOS_DEBUG, "Laptop handling...\n");
+	outb(inb(0x60f) & ~(1 << 5), 0x60f);
 }
 
 struct chip_operations mainboard_ops = {



More information about the coreboot-gerrit mailing list