[coreboot-gerrit] Patch merged into coreboot/master: 9518b56 intel/gma: Clarify code and use dedicated init for Google Peppy

[gerrit at coreboot.org]

the following patch was just integrated into master:
commit 9518b56ab079f4c12eefe83cc9b4fa24b413ebe8
Author: Ronald G. Minnich <rminnich at gmail.com>
Date:   Thu Sep 19 16:45:22 2013 -0700

    intel/gma: Clarify code and use dedicated init for Google Peppy
    
    Peppy had some issues with FUI. We decided it was time to create
    peppy-specific gma.c and i915io.c files. Using yabel and the i915tool,
    we generated a replay attack, then interpolated against the slippy
    i915io.c to get something working.
    
    Also, in preparation for moving code out of the mainboard gma.c to
    generic driver code, we got rid of some hardcodes in the mainboard
    gma.c that have no business being there. The worst were the
    computation of gmch_[m,n] and it turns out that we had some
    long-standing bugs related to confusion about 'bpp'. I've killed the
    word bpp everywhere I could because there are at least 3 things that
    correspond to bpp. We now have framebuffer, pipe, and panel bpp. The
    names are long because I want to avoid all the mistakes we've all been
    making in the last year :-) Sadly, that means a lot of changes not just
    peppy-related, but they are simple and in a good cause.
    
    The test pattern generation is driven by a global variable in
    mainboard/peppy/gma.c.  I've found in the past that it's very useful
    to have a function like this available, as one can activate it while
    using a jtag debugger: halt at the right place in ramstage, set the
    variable to 1, continue. It's not enough code to worry about always
    including.
    
    The last hard-codes for M and N registers are gone, and the function
    to set from generic intel_dp.c code works.  To avoid screen trash on a
    dev mode boot, which we liked but nobody else did :-), we now take the
    time to put a pleasing background color that sort of doubles as a
    power LED.
    
    Rough timing is ramstage start is at 2.2, and dev setup is done at
    3.3. These new platforms are depressingly slow to boot. Rom init alone
    is taking 1.9 seconds. 13 years ago it was 3 seconds from power on to bash
    prompt. These CPUs are at least 10x faster and take much longer to get going.
    
    Future work, once we get this through, is to move more functions to the
    intel driver, and combine the mainboard i915io.c into the mainboard gma.c.
    That separation only existed because i915io.c was generated by a tool, and it
    had lots of ugliness. Most ugliness is gone.
    
    Old-Change-Id: I6a6295b423a41e263f82cef33eacb92a14163321
    Signed-off-by: Ronald G. Minnich <rminnich at gmail.com>
    Reviewed-on: https://chromium-review.googlesource.com/170013
    Reviewed-by: Stefan Reinauer <reinauer at google.com>
    Commit-Queue: Ronald Minnich <rminnich at chromium.org>
    Tested-by: Ronald Minnich <rminnich at chromium.org>
    Reviewed-by: Furquan Shaikh <furquan.m.shaikh at gmail.com>
    (cherry picked from commit 8cdaf73e3602e15925859866714db4d5ec6c947d)
    
    snow: Fix a typo in devicetree.cb that was breaking the snow build.
    
    A typo in a recent change broke the snow build.
    
    Old-Change-Id: I93074e68eb3d21510d974fd8e9c63b3947285afd
    Signed-off-by: Gabe Black <gabeblack at google.com>
    Reviewed-on: https://chromium-review.googlesource.com/171014
    Reviewed-by: Ronald Minnich <rminnich at chromium.org>
    Commit-Queue: Gabe Black <gabeblack at chromium.org>
    Tested-by: Gabe Black <gabeblack at chromium.org>
    (cherry picked from commit 154876c126a6690930141df178485658533096d2)
    
    Squashed a fix into the initial patch and updated nehalem/gma.c
    to have a non-static gtt_poll.
    
    Change-Id: I2f4342c610d87335411da1d6d405171dc80c1f14
    Signed-off-by: Isaac Christensen <isaac.christensen at se-eng.com>
    Reviewed-on: http://review.coreboot.org/6657
    Tested-by: build bot (Jenkins)


See http://review.coreboot.org/6657 for details.

-gerrit