[coreboot-gerrit] New patch to review for coreboot: 29971c1 lenovo/t520: fix usb config & documentation

Nicolas Reinecke (nr@das-labor.org) gerrit at coreboot.org
Sat Aug 23 01:08:02 CEST 2014


Nicolas Reinecke (nr at das-labor.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6742

-gerrit

commit 29971c1140c40091601e431351e1d95474be2e91
Author: Nicolas Reinecke <nr at das-labor.org>
Date:   Sat Aug 23 00:51:49 2014 +0200

    lenovo/t520: fix usb config & documentation
    
    Change-Id: I71398ab2d7ef5b9256795861dd2bebbb0cf32d5f
    Signed-off-by: Nicolas Reinecke <nr at das-labor.org>
---
 src/mainboard/lenovo/t520/romstage.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/mainboard/lenovo/t520/romstage.c b/src/mainboard/lenovo/t520/romstage.c
index 3ad9344..c3cd602 100644
--- a/src/mainboard/lenovo/t520/romstage.c
+++ b/src/mainboard/lenovo/t520/romstage.c
@@ -152,19 +152,19 @@ void main(unsigned long bist)
 		.max_ddr3_freq = 1600,
 		.usb_port_config = {
 			 /* enabled   usb oc pin    length */
-			{ 1, 0, 0x0080 }, /* P0 (left, fan side), OC 0 */
-			{ 1, 1, 0x0080 }, /* P1 (left touchpad side), OC 1 */
-			{ 1, 0, 0x0040 }, /* P2: dock, OC 3 */
+			{ 1, 0, 0x0080 }, /* P0 left dual conn, OC 0 */
+			{ 1, 1, 0x0080 }, /* P1 System onboard USB port (eSATA) (EHCI debug), OC 1 */
+			{ 1, 0, 0x0040 }, /* P2: wimax / wlan */
 			{ 1, 0, 0x0040 }, /* P3: wwan, no OC */
-			{ 1, 0, 0x0080 }, /* P4: Wacom tablet on X230t, otherwise empty */
+			{ 1, 0, 0x0040 }, /* P4: smartcard, otherwise empty */
 			{ 1, 0, 0x0080 }, /* P5: Expresscard, no OC */
-			{ 0, 0, 0x0000 }, /* P6: Empty */
-			{ 1, 0, 0x0080 }, /* P7: dock, no OC */
-			{ 1, 4, 0x0080 }, /* P8: Empty */
-			{ 1, 5, 0x0080 }, /* P9: Right (EHCI debug), OC 5 */
+			{ 0, 0, 0x0000 }, /* P6: empty */
+			{ 1, 0, 0x0080 }, /* P7: to touch panel, no OC */
+			{ 1, 4, 0x0080 }, /* P8: left dual conn, OC4 */
+			{ 1, 5, 0x0080 }, /* P9: to system subcard back right (EHCI debug), OC 5 */
 			{ 1, 0, 0x0040 }, /* P10: fingerprint reader, no OC */
 			{ 1, 0, 0x0040 }, /* P11: bluetooth, no OC. */
-			{ 1, 0, 0x0040 }, /* P12: wlan, no OC */
+			{ 1, 0, 0x0080 }, /* P12: dock, no OC */
 			{ 1, 0, 0x0080 }, /* P13: webcam, no OC */
 		},
 		.ddr_refresh_rate_config = 2, /* Force double refresh rate */



More information about the coreboot-gerrit mailing list