[coreboot-gerrit] New patch to review for coreboot: ce7fe40 gm45: Set D0F0_SKPD on normal boot path

Vladimir Serbinenko (phcoder@gmail.com) gerrit at coreboot.org
Wed Aug 13 23:07:51 CEST 2014


Vladimir Serbinenko (phcoder at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6652

-gerrit

commit ce7fe400fa657575ec065bbccc117f56ecf0f8b1
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date:   Wed Aug 13 23:06:07 2014 +0200

    gm45: Set D0F0_SKPD on normal boot path
    
    Otherwise we get a warning on normal boot.
    
    Change-Id: Ida1e1d23e258438251d4ec2417f93ad14c3b9f7d
    Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
 src/mainboard/lenovo/x200/romstage.c | 3 +++
 src/mainboard/roda/rk9/romstage.c    | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/src/mainboard/lenovo/x200/romstage.c b/src/mainboard/lenovo/x200/romstage.c
index 1facacd..816fde4 100644
--- a/src/mainboard/lenovo/x200/romstage.c
+++ b/src/mainboard/lenovo/x200/romstage.c
@@ -201,6 +201,9 @@ void main(unsigned long bist)
 
 		/* Magic for S3 resume */
 		pci_write_config32(PCI_DEV(0, 0, 0), D0F0_SKPD, SKPAD_ACPI_S3_MAGIC);
+	} else {
+		/* Magic for S3 resume */
+		pci_write_config32(PCI_DEV(0, 0, 0), D0F0_SKPD, SKPAD_NORMAL_BOOT_MAGIC);
 	}
 #endif
 	printk(BIOS_SPEW, "exit main()\n");
diff --git a/src/mainboard/roda/rk9/romstage.c b/src/mainboard/roda/rk9/romstage.c
index 545bd58..3d11fee 100644
--- a/src/mainboard/roda/rk9/romstage.c
+++ b/src/mainboard/roda/rk9/romstage.c
@@ -207,6 +207,9 @@ void main(unsigned long bist)
 
 		/* Magic for S3 resume */
 		pci_write_config32(PCI_DEV(0, 0, 0), D0F0_SKPD, SKPAD_ACPI_S3_MAGIC);
+	} else {
+		/* Magic for S3 resume */
+		pci_write_config32(PCI_DEV(0, 0, 0), D0F0_SKPD, SKPAD_NORMAL_BOOT_MAGIC);
 	}
 #endif
 	printk(BIOS_SPEW, "exit main()\n");



More information about the coreboot-gerrit mailing list