[coreboot-gerrit] New patch to review for coreboot: 20decef libpayload: Reduce media init timeout to 5 seconds.

Isaac Christensen (isaac.christensen@se-eng.com) gerrit at coreboot.org
Wed Aug 13 20:35:35 CEST 2014


Isaac Christensen (isaac.christensen at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6647

-gerrit

commit 20deceff32f25b583253148ea9ad8f8ba40cea5b
Author: Shawn Nematbakhsh <shawnn at chromium.org>
Date:   Thu Sep 12 18:23:09 2013 -0700

    libpayload: Reduce media init timeout to 5 seconds.
    
    Currently, we wait for up to 30 seconds for a device to become ready to
    respond to a TEST_UNIT_READY command. In practice, all media devices become
    ready much sooner. But, certain devices do not function with libpayload's
    USB driver, and always timeout. To provide a better user experience when
    booting with such devices, reduce the timeout to 5 seconds.
    
    Change-Id: Icceab99fa266cdf441847627087eaa5de9b88ecc
    Signed-off-by: Shawn Nematbakhsh <shawnn at chromium.org>
    Reviewed-on: https://chromium-review.googlesource.com/169209
    (cherry picked from commit 9e55204e92adca0476d273565683f211d6803e7a)
    Signed-off-by: Isaac Christensen <isaac.christensen at se-eng.com>
---
 payloads/libpayload/drivers/usb/usbmsc.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/payloads/libpayload/drivers/usb/usbmsc.c b/payloads/libpayload/drivers/usb/usbmsc.c
index f68bee5..1f8c551 100644
--- a/payloads/libpayload/drivers/usb/usbmsc.c
+++ b/payloads/libpayload/drivers/usb/usbmsc.c
@@ -539,8 +539,10 @@ usb_msc_test_unit_ready (usbdev_t *dev)
 	int i;
 	time_t start_time_secs;
 	struct timeval tv;
-	/* SCSI/ATA specs say we have to wait up to 30s. Ugh */
-	const int timeout_secs = 30;
+	/* SCSI/ATA specs say we have to wait up to 30s, but most devices
+	 * are ready much sooner. Use a 5 sec timeout to better accomodate
+	 * devices which fail to respond. */
+	const int timeout_secs = 5;
 
 	usb_debug ("  Waiting for device to become ready...");
 



More information about the coreboot-gerrit mailing list