[coreboot-gerrit] Patch merged into coreboot/master: e9738db libpayload: Make USB transfer functions return amount of bytes

gerrit at coreboot.org gerrit at coreboot.org
Tue Aug 12 22:03:30 CEST 2014


the following patch was just integrated into master:
commit e9738dbe2bb564f7be7930aa5b01e9ae3c1e2288
Author: Julius Werner <jwerner at chromium.org>
Date:   Thu Feb 21 13:41:40 2013 -0800

    libpayload: Make USB transfer functions return amount of bytes
    
    The USB bulk and control transfer functions in libpayload currently
    always return 0 for success and 1 for all errors. This is sufficient for
    current use cases (essentially just mass storage), but other classes
    (like certain Ethernet adapters) need to be able to tell if a transfer
    reached the intended amount of bytes, or if it fell short.
    
    This patch slightly changes that USB API to return -1 on errors, and the
    amount of transferred bytes on successes. All drivers in the current
    libpayload mainline are modified to conform to the new error detection
    model. Any third party users of this API will need to adapt their
    if (...<controller>->bulk/control(...)) checks to
    if (...<controller>->bulk/control(...) < 0) as well.
    
    The host controller drivers for OHCI and EHCI correctly implement the
    new behavior. UHCI and the XHCI stub just comply with the new API by
    returning 0 or -1, but do not actually count the returned bytes.
    
    Signed-off-by: Julius Werner <jwerner at chromium.org>
    Reviewed-on: https://gerrit.chromium.org/gerrit/48308
    Reviewed-by: Gabe Black <gabeblack at chromium.org>
    Reviewed-by: Stefan Reinauer <reinauer at google.com>
    Tested-by: Gabe Black <gabeblack at chromium.org>
    Commit-Queue: Gabe Black <gabeblack at chromium.org>
    
    Updated the patch to support XHCI as well.
    
    Change-Id: Ic2ea2810c5edb992cbe185bc9711d2f8f557cae6
    (cherry picked from commit e39e2d84762a3804653d950a228ed2269c651458)
    Signed-off-by: Isaac Christensen <isaac.christensen at se-eng.com>
    Reviewed-on: http://review.coreboot.org/6390
    Tested-by: build bot (Jenkins)
    Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>
    Reviewed-by: Patrick Georgi <patrick at georgi-clan.de>


See http://review.coreboot.org/6390 for details.

-gerrit



More information about the coreboot-gerrit mailing list