[coreboot-gerrit] New patch to review for coreboot: 3e7976d cpu/intel/model_1067x: avoid null-pointer dereference

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Sat Aug 9 20:48:58 CEST 2014


Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6570

-gerrit

commit 3e7976d393dade063e56247a3a1977d50f9785fc
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Sat Aug 9 20:48:12 2014 +0200

    cpu/intel/model_1067x: avoid null-pointer dereference
    
    Change-Id: I7467d4a947e9e447707e1370b7e639ddddc20d3d
    Found-by: Coverity Scan
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
---
 src/cpu/intel/model_1067x/model_1067x_init.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/cpu/intel/model_1067x/model_1067x_init.c b/src/cpu/intel/model_1067x/model_1067x_init.c
index 4779a51..8e44c78 100644
--- a/src/cpu/intel/model_1067x/model_1067x_init.c
+++ b/src/cpu/intel/model_1067x/model_1067x_init.c
@@ -149,7 +149,8 @@ static void configure_p_states(const char stepping, const char cores)
 		(lapic && lapic->chip_info) ? lapic->chip_info : NULL;
 
 	msr = rdmsr(MSR_EXTENDED_CONFIG);
-	if (conf->slfm && (msr.lo & (1 << 27))) /* Super LFM supported? */
+	/* Super LFM supported? */
+	if (conf && conf->slfm && (msr.lo & (1 << 27)))
 		msr.lo |= (1 << 28); /* Enable Super LFM. */
 	wrmsr(MSR_EXTENDED_CONFIG, msr);
 



More information about the coreboot-gerrit mailing list