[coreboot-gerrit] New patch to review for coreboot: 4323675 util/nvramtool/cli/nvramtool.c: Add newline to error message

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Sat Aug 9 10:00:23 CEST 2014


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6553

-gerrit

commit 43236759b3cda1ad3190e5addc9dc92bf91854dd
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Sat Aug 9 09:33:59 2014 +0200

    util/nvramtool/cli/nvramtool.c: Add newline to error message
    
    Wanting to write a non-existent CMOS parameter an error messages is
    shown without a newline at the end and nvramtool exits.
    
    	user at lenovo_x60t$ sudo util/nvramtool/nvramtool -w touchpad=Enlable
    	nvramtool: CMOS parameter touchpad not found.user at lenovo_x60t$
    
    So add a newline at the end to properly format the output.
    
    	user at lenovo_x60t$ sudo util/nvramtool/nvramtool -w touchpad=Enlable
    	nvramtool: CMOS parameter touchpad not found.
    	user at lenovo_x60t$
    
    Change-Id: Ied431dbc9f94d82e1f4716cfb89ea3d6cf513703
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 util/nvramtool/cli/nvramtool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/nvramtool/cli/nvramtool.c b/util/nvramtool/cli/nvramtool.c
index d5acc58..f83825e 100644
--- a/util/nvramtool/cli/nvramtool.c
+++ b/util/nvramtool/cli/nvramtool.c
@@ -615,7 +615,7 @@ static void set_one_param(const char name[], const char value[])
 	unsigned long long n;
 
 	if (is_checksum_name(name) || (e = find_cmos_entry(name)) == NULL) {
-		fprintf(stderr, "%s: CMOS parameter %s not found.", prog_name,
+		fprintf(stderr, "%s: CMOS parameter %s not found.\n", prog_name,
 			name);
 		exit(1);
 	}



More information about the coreboot-gerrit mailing list