[coreboot-gerrit] Patch set updated for coreboot: ed60b8d superio/smsc/sio1036: Clean up RAMstage superio.c component
Edward O'Callaghan (eocallaghan@alterapraxis.com)
gerrit at coreboot.org
Wed Aug 6 02:25:29 CEST 2014
Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6465
-gerrit
commit ed60b8d6a9d859c57548e7068e8df2212ea3c4cd
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date: Sat Aug 2 20:45:13 2014 +1000
superio/smsc/sio1036: Clean up RAMstage superio.c component
Remove spurious includes, unused variables and some wasted new lines.
Re-organise things to be consistent with other superio's.
Change-Id: I959bab2f7a83a1b9160d7f010a0de9638b30cf07
Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
src/superio/smsc/sio1036/superio.c | 42 ++++++++++++--------------------------
1 file changed, 13 insertions(+), 29 deletions(-)
diff --git a/src/superio/smsc/sio1036/superio.c b/src/superio/smsc/sio1036/superio.c
index d2bfd8d..e9ed6c3 100644
--- a/src/superio/smsc/sio1036/superio.c
+++ b/src/superio/smsc/sio1036/superio.c
@@ -24,20 +24,16 @@
#include <device/pnp.h>
#include <superio/conf_mode.h>
#include <console/console.h>
-#include <device/smbus.h>
-#include <string.h>
-#include <pc80/keyboard.h>
#include <stdlib.h>
-#include "sio1036.h"
-/* Forward declarations */
-static void enable_dev(device_t dev);
-static void sio1036_init(device_t dev);
+#include "sio1036.h"
-struct chip_operations superio_smsc_sio1036_ops = {
- CHIP_NAME("SMSC SIO1036 Super I/O")
- .enable_dev = enable_dev
-};
+static void sio1036_init(device_t dev)
+{
+ if (!dev->enabled) {
+ return;
+ }
+}
static struct device_operations ops = {
.read_resources = pnp_read_resources,
@@ -49,27 +45,15 @@ static struct device_operations ops = {
};
static struct pnp_info pnp_dev_info[] = {
- {},
+ { &ops, SIO1036_SP1, PNP_IO0 | PNP_IRQ0, {0x07f8, 0}, },
};
static void enable_dev(device_t dev)
{
- pnp_enable_devices(dev, &pnp_ops, ARRAY_SIZE(pnp_dev_info), pnp_dev_info);
+ pnp_enable_devices(dev, &ops, ARRAY_SIZE(pnp_dev_info), pnp_dev_info);
}
-static void sio1036_init(device_t dev)
-{
- struct resource *res0, *res1;
-
-
-
- if (!dev->enabled) {
- return;
- }
-
- switch(dev->path.pnp.device) {
-
- default:
- break;
- }
-}
+struct chip_operations superio_smsc_sio1036_ops = {
+ CHIP_NAME("SMSC SIO1036 Super I/O")
+ .enable_dev = enable_dev
+};
More information about the coreboot-gerrit
mailing list