[coreboot-gerrit] New patch to review for coreboot: 4888822 ifdtool: Avoid potential buffer overflow

[Patrick Georgi (patrick@georgi-clan.de)]

Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6476

-gerrit

commit 48888220e16d3bd8f96d12e8e27df1ec1dad787d
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Sun Aug 3 12:14:25 2014 +0200

    ifdtool: Avoid potential buffer overflow
    
    Filenames of 4091 bytes or more lead to a buffer overflow.
    
    Change-Id: I1b4b3932af096f0fcbfb783ab708ed273d3a844e
    Found-by: Coverity Scan
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
---
 util/ifdtool/ifdtool.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c
index 0425b1c..deef1b1 100644
--- a/util/ifdtool/ifdtool.c
+++ b/util/ifdtool/ifdtool.c
@@ -552,7 +552,8 @@ static void write_image(char *filename, char *image, int size)
 	char new_filename[FILENAME_MAX]; // allow long file names
 	int new_fd;
 
-	strncpy(new_filename, filename, FILENAME_MAX);
+	// - 5: leave room for ".new\0"
+	strncpy(new_filename, filename, FILENAME_MAX - 5);
 	strncat(new_filename, ".new", FILENAME_MAX - strlen(filename));
 
 	printf("Writing new image to %s\n", new_filename);