[coreboot-gerrit] New patch to review for coreboot: 1bba2b6 mainboard/*/acpi/ide.asl: Serialize ACPI methods to avoid races.

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Sat Apr 5 17:00:58 CEST 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5458

-gerrit

commit 1bba2b6759c42c2fbd47f9dc1c08597b8567976a
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Sun Apr 6 01:57:42 2014 +1100

    mainboard/*/acpi/ide.asl: Serialize ACPI methods to avoid races.
    
    Fix the remark introduced in ACPICA version 20130517 that gives the
    following explanation:
    
       If a thread blocks within the method for any reason, and another thread
       enters the method, the method will fail because an attempt will be
       made to create the same (named) object twice.
    
       In this case, issue a remark that the method should be marked
       serialized. ACPICA BZ 909.
    
    This change fixes issues that show up with the Ubuntu firmware test
    suite (fwts) ACPI table sanity checker.
    
    Change-Id: I49e3050a2a5aece6f031122b0211c056938d1a89
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/mainboard/advansus/a785e-i/acpi/ide.asl       | 8 ++++----
 src/mainboard/amd/inagua/acpi/ide.asl             | 8 ++++----
 src/mainboard/amd/persimmon/acpi/ide.asl          | 8 ++++----
 src/mainboard/amd/south_station/acpi/ide.asl      | 8 ++++----
 src/mainboard/amd/torpedo/acpi/ide.asl            | 8 ++++----
 src/mainboard/amd/union_station/acpi/ide.asl      | 8 ++++----
 src/mainboard/asrock/e350m1/acpi/ide.asl          | 8 ++++----
 src/mainboard/asus/m5a88-v/acpi/ide.asl           | 8 ++++----
 src/mainboard/avalue/eax-785e/acpi/ide.asl        | 8 ++++----
 src/mainboard/jetway/nf81-t56n-lf/acpi/ide.asl    | 8 ++++----
 src/mainboard/lippert/frontrunner-af/acpi/ide.asl | 8 ++++----
 src/mainboard/lippert/toucan-af/acpi/ide.asl      | 8 ++++----
 src/mainboard/supermicro/h8qgi/acpi/ide.asl       | 8 ++++----
 src/mainboard/supermicro/h8scm/acpi/ide.asl       | 8 ++++----
 src/mainboard/tyan/s8226/acpi/ide.asl             | 8 ++++----
 15 files changed, 60 insertions(+), 60 deletions(-)

diff --git a/src/mainboard/advansus/a785e-i/acpi/ide.asl b/src/mainboard/advansus/a785e-i/acpi/ide.asl
index b3aed9c..4071f85 100644
--- a/src/mainboard/advansus/a785e-i/acpi/ide.asl
+++ b/src/mainboard/advansus/a785e-i/acpi/ide.asl
@@ -77,7 +77,7 @@ Method(GTTM, 1) /* get total time*/
 Device(PRID)
 {
 	Name (_ADR, Zero)
-	Method(_GTM, 0)
+	Method(_GTM, 0, Serialized)
 	{
 		NAME(OTBF, Buffer(20) { /* out buffer */
 			0xFF, 0xFF, 0xFF, 0xFF,
@@ -122,7 +122,7 @@ Device(PRID)
 		Return(OTBF) /* out buffer */
 	}				/* End Method(_GTM) */
 
-	Method(_STM, 3, NotSerialized)
+	Method(_STM, 3, Serialized)
 	{
 		NAME(INBF, Buffer(20) { /* in buffer */
 			0xFF, 0xFF, 0xFF, 0xFF,
@@ -173,7 +173,7 @@ Device(PRID)
 	Device(MST)
 	{
 		Name(_ADR, 0)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
 			Name(CMBF, Buffer(21) {
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
@@ -209,7 +209,7 @@ Device(PRID)
 	Device(SLAV)
 	{
 		Name(_ADR, 1)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
 			Name(CMBF, Buffer(21) {
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
diff --git a/src/mainboard/amd/inagua/acpi/ide.asl b/src/mainboard/amd/inagua/acpi/ide.asl
index b3aed9c..4071f85 100644
--- a/src/mainboard/amd/inagua/acpi/ide.asl
+++ b/src/mainboard/amd/inagua/acpi/ide.asl
@@ -77,7 +77,7 @@ Method(GTTM, 1) /* get total time*/
 Device(PRID)
 {
 	Name (_ADR, Zero)
-	Method(_GTM, 0)
+	Method(_GTM, 0, Serialized)
 	{
 		NAME(OTBF, Buffer(20) { /* out buffer */
 			0xFF, 0xFF, 0xFF, 0xFF,
@@ -122,7 +122,7 @@ Device(PRID)
 		Return(OTBF) /* out buffer */
 	}				/* End Method(_GTM) */
 
-	Method(_STM, 3, NotSerialized)
+	Method(_STM, 3, Serialized)
 	{
 		NAME(INBF, Buffer(20) { /* in buffer */
 			0xFF, 0xFF, 0xFF, 0xFF,
@@ -173,7 +173,7 @@ Device(PRID)
 	Device(MST)
 	{
 		Name(_ADR, 0)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
 			Name(CMBF, Buffer(21) {
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
@@ -209,7 +209,7 @@ Device(PRID)
 	Device(SLAV)
 	{
 		Name(_ADR, 1)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
 			Name(CMBF, Buffer(21) {
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
diff --git a/src/mainboard/amd/persimmon/acpi/ide.asl b/src/mainboard/amd/persimmon/acpi/ide.asl
index b3aed9c..4071f85 100644
--- a/src/mainboard/amd/persimmon/acpi/ide.asl
+++ b/src/mainboard/amd/persimmon/acpi/ide.asl
@@ -77,7 +77,7 @@ Method(GTTM, 1) /* get total time*/
 Device(PRID)
 {
 	Name (_ADR, Zero)
-	Method(_GTM, 0)
+	Method(_GTM, 0, Serialized)
 	{
 		NAME(OTBF, Buffer(20) { /* out buffer */
 			0xFF, 0xFF, 0xFF, 0xFF,
@@ -122,7 +122,7 @@ Device(PRID)
 		Return(OTBF) /* out buffer */
 	}				/* End Method(_GTM) */
 
-	Method(_STM, 3, NotSerialized)
+	Method(_STM, 3, Serialized)
 	{
 		NAME(INBF, Buffer(20) { /* in buffer */
 			0xFF, 0xFF, 0xFF, 0xFF,
@@ -173,7 +173,7 @@ Device(PRID)
 	Device(MST)
 	{
 		Name(_ADR, 0)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
 			Name(CMBF, Buffer(21) {
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
@@ -209,7 +209,7 @@ Device(PRID)
 	Device(SLAV)
 	{
 		Name(_ADR, 1)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
 			Name(CMBF, Buffer(21) {
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
diff --git a/src/mainboard/amd/south_station/acpi/ide.asl b/src/mainboard/amd/south_station/acpi/ide.asl
index b3aed9c..4071f85 100644
--- a/src/mainboard/amd/south_station/acpi/ide.asl
+++ b/src/mainboard/amd/south_station/acpi/ide.asl
@@ -77,7 +77,7 @@ Method(GTTM, 1) /* get total time*/
 Device(PRID)
 {
 	Name (_ADR, Zero)
-	Method(_GTM, 0)
+	Method(_GTM, 0, Serialized)
 	{
 		NAME(OTBF, Buffer(20) { /* out buffer */
 			0xFF, 0xFF, 0xFF, 0xFF,
@@ -122,7 +122,7 @@ Device(PRID)
 		Return(OTBF) /* out buffer */
 	}				/* End Method(_GTM) */
 
-	Method(_STM, 3, NotSerialized)
+	Method(_STM, 3, Serialized)
 	{
 		NAME(INBF, Buffer(20) { /* in buffer */
 			0xFF, 0xFF, 0xFF, 0xFF,
@@ -173,7 +173,7 @@ Device(PRID)
 	Device(MST)
 	{
 		Name(_ADR, 0)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
 			Name(CMBF, Buffer(21) {
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
@@ -209,7 +209,7 @@ Device(PRID)
 	Device(SLAV)
 	{
 		Name(_ADR, 1)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
 			Name(CMBF, Buffer(21) {
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
diff --git a/src/mainboard/amd/torpedo/acpi/ide.asl b/src/mainboard/amd/torpedo/acpi/ide.asl
index b3aed9c..4071f85 100644
--- a/src/mainboard/amd/torpedo/acpi/ide.asl
+++ b/src/mainboard/amd/torpedo/acpi/ide.asl
@@ -77,7 +77,7 @@ Method(GTTM, 1) /* get total time*/
 Device(PRID)
 {
 	Name (_ADR, Zero)
-	Method(_GTM, 0)
+	Method(_GTM, 0, Serialized)
 	{
 		NAME(OTBF, Buffer(20) { /* out buffer */
 			0xFF, 0xFF, 0xFF, 0xFF,
@@ -122,7 +122,7 @@ Device(PRID)
 		Return(OTBF) /* out buffer */
 	}				/* End Method(_GTM) */
 
-	Method(_STM, 3, NotSerialized)
+	Method(_STM, 3, Serialized)
 	{
 		NAME(INBF, Buffer(20) { /* in buffer */
 			0xFF, 0xFF, 0xFF, 0xFF,
@@ -173,7 +173,7 @@ Device(PRID)
 	Device(MST)
 	{
 		Name(_ADR, 0)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
 			Name(CMBF, Buffer(21) {
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
@@ -209,7 +209,7 @@ Device(PRID)
 	Device(SLAV)
 	{
 		Name(_ADR, 1)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
 			Name(CMBF, Buffer(21) {
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
diff --git a/src/mainboard/amd/union_station/acpi/ide.asl b/src/mainboard/amd/union_station/acpi/ide.asl
index b3aed9c..4071f85 100644
--- a/src/mainboard/amd/union_station/acpi/ide.asl
+++ b/src/mainboard/amd/union_station/acpi/ide.asl
@@ -77,7 +77,7 @@ Method(GTTM, 1) /* get total time*/
 Device(PRID)
 {
 	Name (_ADR, Zero)
-	Method(_GTM, 0)
+	Method(_GTM, 0, Serialized)
 	{
 		NAME(OTBF, Buffer(20) { /* out buffer */
 			0xFF, 0xFF, 0xFF, 0xFF,
@@ -122,7 +122,7 @@ Device(PRID)
 		Return(OTBF) /* out buffer */
 	}				/* End Method(_GTM) */
 
-	Method(_STM, 3, NotSerialized)
+	Method(_STM, 3, Serialized)
 	{
 		NAME(INBF, Buffer(20) { /* in buffer */
 			0xFF, 0xFF, 0xFF, 0xFF,
@@ -173,7 +173,7 @@ Device(PRID)
 	Device(MST)
 	{
 		Name(_ADR, 0)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
 			Name(CMBF, Buffer(21) {
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
@@ -209,7 +209,7 @@ Device(PRID)
 	Device(SLAV)
 	{
 		Name(_ADR, 1)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
 			Name(CMBF, Buffer(21) {
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
diff --git a/src/mainboard/asrock/e350m1/acpi/ide.asl b/src/mainboard/asrock/e350m1/acpi/ide.asl
index b3aed9c..4071f85 100644
--- a/src/mainboard/asrock/e350m1/acpi/ide.asl
+++ b/src/mainboard/asrock/e350m1/acpi/ide.asl
@@ -77,7 +77,7 @@ Method(GTTM, 1) /* get total time*/
 Device(PRID)
 {
 	Name (_ADR, Zero)
-	Method(_GTM, 0)
+	Method(_GTM, 0, Serialized)
 	{
 		NAME(OTBF, Buffer(20) { /* out buffer */
 			0xFF, 0xFF, 0xFF, 0xFF,
@@ -122,7 +122,7 @@ Device(PRID)
 		Return(OTBF) /* out buffer */
 	}				/* End Method(_GTM) */
 
-	Method(_STM, 3, NotSerialized)
+	Method(_STM, 3, Serialized)
 	{
 		NAME(INBF, Buffer(20) { /* in buffer */
 			0xFF, 0xFF, 0xFF, 0xFF,
@@ -173,7 +173,7 @@ Device(PRID)
 	Device(MST)
 	{
 		Name(_ADR, 0)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
 			Name(CMBF, Buffer(21) {
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
@@ -209,7 +209,7 @@ Device(PRID)
 	Device(SLAV)
 	{
 		Name(_ADR, 1)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
 			Name(CMBF, Buffer(21) {
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
diff --git a/src/mainboard/asus/m5a88-v/acpi/ide.asl b/src/mainboard/asus/m5a88-v/acpi/ide.asl
index b3aed9c..4071f85 100644
--- a/src/mainboard/asus/m5a88-v/acpi/ide.asl
+++ b/src/mainboard/asus/m5a88-v/acpi/ide.asl
@@ -77,7 +77,7 @@ Method(GTTM, 1) /* get total time*/
 Device(PRID)
 {
 	Name (_ADR, Zero)
-	Method(_GTM, 0)
+	Method(_GTM, 0, Serialized)
 	{
 		NAME(OTBF, Buffer(20) { /* out buffer */
 			0xFF, 0xFF, 0xFF, 0xFF,
@@ -122,7 +122,7 @@ Device(PRID)
 		Return(OTBF) /* out buffer */
 	}				/* End Method(_GTM) */
 
-	Method(_STM, 3, NotSerialized)
+	Method(_STM, 3, Serialized)
 	{
 		NAME(INBF, Buffer(20) { /* in buffer */
 			0xFF, 0xFF, 0xFF, 0xFF,
@@ -173,7 +173,7 @@ Device(PRID)
 	Device(MST)
 	{
 		Name(_ADR, 0)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
 			Name(CMBF, Buffer(21) {
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
@@ -209,7 +209,7 @@ Device(PRID)
 	Device(SLAV)
 	{
 		Name(_ADR, 1)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
 			Name(CMBF, Buffer(21) {
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
diff --git a/src/mainboard/avalue/eax-785e/acpi/ide.asl b/src/mainboard/avalue/eax-785e/acpi/ide.asl
index b3aed9c..4071f85 100644
--- a/src/mainboard/avalue/eax-785e/acpi/ide.asl
+++ b/src/mainboard/avalue/eax-785e/acpi/ide.asl
@@ -77,7 +77,7 @@ Method(GTTM, 1) /* get total time*/
 Device(PRID)
 {
 	Name (_ADR, Zero)
-	Method(_GTM, 0)
+	Method(_GTM, 0, Serialized)
 	{
 		NAME(OTBF, Buffer(20) { /* out buffer */
 			0xFF, 0xFF, 0xFF, 0xFF,
@@ -122,7 +122,7 @@ Device(PRID)
 		Return(OTBF) /* out buffer */
 	}				/* End Method(_GTM) */
 
-	Method(_STM, 3, NotSerialized)
+	Method(_STM, 3, Serialized)
 	{
 		NAME(INBF, Buffer(20) { /* in buffer */
 			0xFF, 0xFF, 0xFF, 0xFF,
@@ -173,7 +173,7 @@ Device(PRID)
 	Device(MST)
 	{
 		Name(_ADR, 0)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
 			Name(CMBF, Buffer(21) {
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
@@ -209,7 +209,7 @@ Device(PRID)
 	Device(SLAV)
 	{
 		Name(_ADR, 1)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
 			Name(CMBF, Buffer(21) {
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
diff --git a/src/mainboard/jetway/nf81-t56n-lf/acpi/ide.asl b/src/mainboard/jetway/nf81-t56n-lf/acpi/ide.asl
index b3aed9c..4071f85 100644
--- a/src/mainboard/jetway/nf81-t56n-lf/acpi/ide.asl
+++ b/src/mainboard/jetway/nf81-t56n-lf/acpi/ide.asl
@@ -77,7 +77,7 @@ Method(GTTM, 1) /* get total time*/
 Device(PRID)
 {
 	Name (_ADR, Zero)
-	Method(_GTM, 0)
+	Method(_GTM, 0, Serialized)
 	{
 		NAME(OTBF, Buffer(20) { /* out buffer */
 			0xFF, 0xFF, 0xFF, 0xFF,
@@ -122,7 +122,7 @@ Device(PRID)
 		Return(OTBF) /* out buffer */
 	}				/* End Method(_GTM) */
 
-	Method(_STM, 3, NotSerialized)
+	Method(_STM, 3, Serialized)
 	{
 		NAME(INBF, Buffer(20) { /* in buffer */
 			0xFF, 0xFF, 0xFF, 0xFF,
@@ -173,7 +173,7 @@ Device(PRID)
 	Device(MST)
 	{
 		Name(_ADR, 0)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
 			Name(CMBF, Buffer(21) {
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
@@ -209,7 +209,7 @@ Device(PRID)
 	Device(SLAV)
 	{
 		Name(_ADR, 1)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
 			Name(CMBF, Buffer(21) {
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
diff --git a/src/mainboard/lippert/frontrunner-af/acpi/ide.asl b/src/mainboard/lippert/frontrunner-af/acpi/ide.asl
index b3aed9c..4071f85 100644
--- a/src/mainboard/lippert/frontrunner-af/acpi/ide.asl
+++ b/src/mainboard/lippert/frontrunner-af/acpi/ide.asl
@@ -77,7 +77,7 @@ Method(GTTM, 1) /* get total time*/
 Device(PRID)
 {
 	Name (_ADR, Zero)
-	Method(_GTM, 0)
+	Method(_GTM, 0, Serialized)
 	{
 		NAME(OTBF, Buffer(20) { /* out buffer */
 			0xFF, 0xFF, 0xFF, 0xFF,
@@ -122,7 +122,7 @@ Device(PRID)
 		Return(OTBF) /* out buffer */
 	}				/* End Method(_GTM) */
 
-	Method(_STM, 3, NotSerialized)
+	Method(_STM, 3, Serialized)
 	{
 		NAME(INBF, Buffer(20) { /* in buffer */
 			0xFF, 0xFF, 0xFF, 0xFF,
@@ -173,7 +173,7 @@ Device(PRID)
 	Device(MST)
 	{
 		Name(_ADR, 0)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
 			Name(CMBF, Buffer(21) {
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
@@ -209,7 +209,7 @@ Device(PRID)
 	Device(SLAV)
 	{
 		Name(_ADR, 1)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
 			Name(CMBF, Buffer(21) {
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
diff --git a/src/mainboard/lippert/toucan-af/acpi/ide.asl b/src/mainboard/lippert/toucan-af/acpi/ide.asl
index b3aed9c..4071f85 100644
--- a/src/mainboard/lippert/toucan-af/acpi/ide.asl
+++ b/src/mainboard/lippert/toucan-af/acpi/ide.asl
@@ -77,7 +77,7 @@ Method(GTTM, 1) /* get total time*/
 Device(PRID)
 {
 	Name (_ADR, Zero)
-	Method(_GTM, 0)
+	Method(_GTM, 0, Serialized)
 	{
 		NAME(OTBF, Buffer(20) { /* out buffer */
 			0xFF, 0xFF, 0xFF, 0xFF,
@@ -122,7 +122,7 @@ Device(PRID)
 		Return(OTBF) /* out buffer */
 	}				/* End Method(_GTM) */
 
-	Method(_STM, 3, NotSerialized)
+	Method(_STM, 3, Serialized)
 	{
 		NAME(INBF, Buffer(20) { /* in buffer */
 			0xFF, 0xFF, 0xFF, 0xFF,
@@ -173,7 +173,7 @@ Device(PRID)
 	Device(MST)
 	{
 		Name(_ADR, 0)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
 			Name(CMBF, Buffer(21) {
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
@@ -209,7 +209,7 @@ Device(PRID)
 	Device(SLAV)
 	{
 		Name(_ADR, 1)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
 			Name(CMBF, Buffer(21) {
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
diff --git a/src/mainboard/supermicro/h8qgi/acpi/ide.asl b/src/mainboard/supermicro/h8qgi/acpi/ide.asl
index b3aed9c..4071f85 100644
--- a/src/mainboard/supermicro/h8qgi/acpi/ide.asl
+++ b/src/mainboard/supermicro/h8qgi/acpi/ide.asl
@@ -77,7 +77,7 @@ Method(GTTM, 1) /* get total time*/
 Device(PRID)
 {
 	Name (_ADR, Zero)
-	Method(_GTM, 0)
+	Method(_GTM, 0, Serialized)
 	{
 		NAME(OTBF, Buffer(20) { /* out buffer */
 			0xFF, 0xFF, 0xFF, 0xFF,
@@ -122,7 +122,7 @@ Device(PRID)
 		Return(OTBF) /* out buffer */
 	}				/* End Method(_GTM) */
 
-	Method(_STM, 3, NotSerialized)
+	Method(_STM, 3, Serialized)
 	{
 		NAME(INBF, Buffer(20) { /* in buffer */
 			0xFF, 0xFF, 0xFF, 0xFF,
@@ -173,7 +173,7 @@ Device(PRID)
 	Device(MST)
 	{
 		Name(_ADR, 0)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
 			Name(CMBF, Buffer(21) {
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
@@ -209,7 +209,7 @@ Device(PRID)
 	Device(SLAV)
 	{
 		Name(_ADR, 1)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
 			Name(CMBF, Buffer(21) {
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
diff --git a/src/mainboard/supermicro/h8scm/acpi/ide.asl b/src/mainboard/supermicro/h8scm/acpi/ide.asl
index b3aed9c..4071f85 100644
--- a/src/mainboard/supermicro/h8scm/acpi/ide.asl
+++ b/src/mainboard/supermicro/h8scm/acpi/ide.asl
@@ -77,7 +77,7 @@ Method(GTTM, 1) /* get total time*/
 Device(PRID)
 {
 	Name (_ADR, Zero)
-	Method(_GTM, 0)
+	Method(_GTM, 0, Serialized)
 	{
 		NAME(OTBF, Buffer(20) { /* out buffer */
 			0xFF, 0xFF, 0xFF, 0xFF,
@@ -122,7 +122,7 @@ Device(PRID)
 		Return(OTBF) /* out buffer */
 	}				/* End Method(_GTM) */
 
-	Method(_STM, 3, NotSerialized)
+	Method(_STM, 3, Serialized)
 	{
 		NAME(INBF, Buffer(20) { /* in buffer */
 			0xFF, 0xFF, 0xFF, 0xFF,
@@ -173,7 +173,7 @@ Device(PRID)
 	Device(MST)
 	{
 		Name(_ADR, 0)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
 			Name(CMBF, Buffer(21) {
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
@@ -209,7 +209,7 @@ Device(PRID)
 	Device(SLAV)
 	{
 		Name(_ADR, 1)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
 			Name(CMBF, Buffer(21) {
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
diff --git a/src/mainboard/tyan/s8226/acpi/ide.asl b/src/mainboard/tyan/s8226/acpi/ide.asl
index b3aed9c..4071f85 100644
--- a/src/mainboard/tyan/s8226/acpi/ide.asl
+++ b/src/mainboard/tyan/s8226/acpi/ide.asl
@@ -77,7 +77,7 @@ Method(GTTM, 1) /* get total time*/
 Device(PRID)
 {
 	Name (_ADR, Zero)
-	Method(_GTM, 0)
+	Method(_GTM, 0, Serialized)
 	{
 		NAME(OTBF, Buffer(20) { /* out buffer */
 			0xFF, 0xFF, 0xFF, 0xFF,
@@ -122,7 +122,7 @@ Device(PRID)
 		Return(OTBF) /* out buffer */
 	}				/* End Method(_GTM) */
 
-	Method(_STM, 3, NotSerialized)
+	Method(_STM, 3, Serialized)
 	{
 		NAME(INBF, Buffer(20) { /* in buffer */
 			0xFF, 0xFF, 0xFF, 0xFF,
@@ -173,7 +173,7 @@ Device(PRID)
 	Device(MST)
 	{
 		Name(_ADR, 0)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
 			Name(CMBF, Buffer(21) {
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
@@ -209,7 +209,7 @@ Device(PRID)
 	Device(SLAV)
 	{
 		Name(_ADR, 1)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
 			Name(CMBF, Buffer(21) {
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,



More information about the coreboot-gerrit mailing list