[coreboot-gerrit] New patch to review for coreboot: b60790b AMD Olive Hill: fix Ubuntu HDMI audio issue

Siyuan Wang (wangsiyuanbuaa@gmail.com) gerrit at coreboot.org
Sun Sep 22 09:54:42 CEST 2013


Siyuan Wang (wangsiyuanbuaa at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3934

-gerrit

commit b60790b866f8b13e3456a3fb1df4323889733fed
Author: WANG Siyuan <wangsiyuanbuaa at gmail.com>
Date:   Sun Sep 22 15:20:37 2013 +0800

    AMD Olive Hill: fix Ubuntu HDMI audio issue
    
    Ubuntu's HDMI audio has noise and echo. Disable NoSnoopEnable can
    resolve this issue.
    I have tested on Ubuntu 13.04 with latest graphic driver.
    
    Change-Id: I5d2dddb1b7469d56cd64e3c1e0f4c6c6f095b4ab
    Signed-off-by: WANG Siyuan <SiYuan.Wang at amd.com>
    Signed-off-by: WANG Siyuan <wangsiyuanbuaa at gmail.com>
---
 src/mainboard/amd/olivehill/get_bus_conf.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/mainboard/amd/olivehill/get_bus_conf.c b/src/mainboard/amd/olivehill/get_bus_conf.c
index 0d379d5..892471a 100644
--- a/src/mainboard/amd/olivehill/get_bus_conf.c
+++ b/src/mainboard/amd/olivehill/get_bus_conf.c
@@ -54,6 +54,7 @@ void get_bus_conf(void)
 {
 	u32 apicid_base;
 	u32 status;
+	u32 value;
 
 	device_t dev;
 	int i, j;
@@ -98,6 +99,12 @@ void get_bus_conf(void)
 	pci_write_config32(dev, 0xF8, 0);
 	pci_write_config32(dev, 0xFC, 5); /* TODO: move it to dsdt.asl */
 
+	/* disable No Snoop */
+	dev = dev_find_slot(0, PCI_DEVFN(1, 1));
+	value = pci_read_config32(dev, 0x60);
+	value &= ~(1 << 11);
+	pci_write_config32(dev, 0x60, value);
+
 	sbdn_yangtze = 0;
 
 	for (i = 0; i < 3; i++) {



More information about the coreboot-gerrit mailing list