[coreboot-gerrit] Patch merged into coreboot/master: d0299e4 southbridge/intel/i82801ix/lpc.c: Remove unused variable `dummy`

gerrit at coreboot.org gerrit at coreboot.org
Wed Oct 30 16:18:05 CET 2013

the following patch was just integrated into master:
commit d0299e4b5178ce8f8b986674cece3e07519f2dff
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Mon Oct 21 09:28:19 2013 +0200

    southbridge/intel/i82801ix/lpc.c: Remove unused variable `dummy`
    Removing `-Wno-unused-but-set-variable` from `CFLAGS` the build for
    QEMU Q35 and Roda RK9, both using the Intel 82801Ix southbridge, fail
    with the following error.
    	src/southbridge/intel/i82801ix/lpc.c: In function 'i82801ix_enable_apic':
    	src/southbridge/intel/i82801ix/lpc.c:45:5: error: variable 'dummy' set but not used [-Werror=unused-but-set-variable]
    	cc1: all warnings being treated as errors
    Removing `dummy` should be safe as GCC probably optimizes it away before
    anyway. That no dummy variable is used for an RCBA [1] access in Intel
    Lynx Point supports that this can be dropped safely.
    [1] root complex base address
    [2] src/southbridge/intel/lynxpoint/early_pch.c
    Change-Id: I1c138a3498228dbd025f68d5e6af0acc29ed3460
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-on: http://review.coreboot.org/3982
    Tested-by: build bot (Jenkins)
    Reviewed-by: Aaron Durbin <adurbin at google.com>

See http://review.coreboot.org/3982 for details.


More information about the coreboot-gerrit mailing list