[coreboot-gerrit] Patch set updated for coreboot: ed24817 Require only one failed boot to switch to fallback in X86_BOOTBLOCK_NORMAL mode.

Denis Carikli (GNUtoo@no-log.org) gerrit at coreboot.org
Sun Oct 27 13:56:42 CET 2013


Denis Carikli (GNUtoo at no-log.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3991

-gerrit

commit ed2481770a0c4dac2e36b8e064a6279bc64fff49
Author: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
Date:   Sun Oct 20 23:37:35 2013 +0200

    Require only one failed boot to switch to fallback in X86_BOOTBLOCK_NORMAL mode.
    
    src/arch/x86/Kconfig defines MAX_REBOOT_CNT as 3.
    If that value is not overrided, then the coreboot image gets it too.
    
    At the end of a successfull boot, with CONFIG_KEEP_BOOT_COUNT,
      the reboot_bits cmos option is increased by one.
    
    In case of a failed boot, the user probably doesn't know that coreboot will
      only switch to fallback after 3 failed boots, and will act as if the laptop
      will not boot anymore with its current coreboot image.
    
    This patch was tested on the Lenovo X60.
    
    Change-Id: I746df11c933dfe62e01e1591479ca96a84907dc0
    Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
---
 src/arch/x86/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig
index 0a21fcc..9610a5b 100644
--- a/src/arch/x86/Kconfig
+++ b/src/arch/x86/Kconfig
@@ -46,7 +46,7 @@ config STACK_SIZE
 # TODO: Improve description.
 config MAX_REBOOT_CNT
 	int
-	default 3
+	default 1
 
 # This is something you almost certainly don't want to mess with.
 # How many SIPIs do we send when starting up APs and cores?



More information about the coreboot-gerrit mailing list