[coreboot-gerrit] Patch set updated for coreboot: d998ccd ck804 lpc: use PCI_BASE_ADDRESS_1 instead of 0x14

Jonathan A. Kollasch (jakllsch@kollasch.net) gerrit at coreboot.org
Fri Oct 11 23:12:37 CEST 2013


Jonathan A. Kollasch (jakllsch at kollasch.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3962

-gerrit

commit d998ccdcfcda8d9f755e207695105f81c82a725b
Author: Jonathan A. Kollasch <jakllsch at kollasch.net>
Date:   Fri Oct 11 16:09:37 2013 -0500

    ck804 lpc: use PCI_BASE_ADDRESS_1 instead of 0x14
    
    Change-Id: I752a4a890e1f610651a2c688cf42350ce8e9deaa
    Signed-off-by: Jonathan A. Kollasch <jakllsch at kollasch.net>
---
 src/southbridge/nvidia/ck804/lpc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/southbridge/nvidia/ck804/lpc.c b/src/southbridge/nvidia/ck804/lpc.c
index c3f24bc..4b33a3c 100644
--- a/src/southbridge/nvidia/ck804/lpc.c
+++ b/src/southbridge/nvidia/ck804/lpc.c
@@ -205,7 +205,7 @@ static void ck804_lpc_read_resources(device_t dev)
 		     IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
 
 	if (dev->device != PCI_DEVICE_ID_NVIDIA_CK804_SLAVE) {
-		res = find_resource(dev, 0x14); /* IOAPIC */
+		res = find_resource(dev, PCI_BASE_ADDRESS_1); /* IOAPIC */
 		if (res) {
 			res->base = IO_APIC_ADDR;
 			res->flags |= IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
@@ -226,9 +226,9 @@ static void ck804_lpc_set_resources(device_t dev)
 	pci_dev_set_resources(dev);
 
 	/* APIC */
-	res = find_resource(dev, 0x14);
+	res = find_resource(dev, PCI_BASE_ADDRESS_1);
 	if (res) {
-		pci_write_config32(dev, 0x14, res->base);
+		pci_write_config32(dev, PCI_BASE_ADDRESS_1, res->base);
 		res->flags |= IORESOURCE_STORED;
 		report_resource_stored(dev, res, "");
 	}



More information about the coreboot-gerrit mailing list