[coreboot-gerrit] Patch merged into coreboot/master: d67c5db slippy: Add on-board devices and configure GPIO irq/wake

gerrit at coreboot.org gerrit at coreboot.org
Mon Nov 25 23:45:47 CET 2013

the following patch was just integrated into master:
commit d67c5dbf06f009b705bc0c2b7278504bb538d36e
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Fri May 24 11:27:12 2013 -0700

    slippy: Add on-board devices and configure GPIO irq/wake
    Add the onboard I2C devices for Slippy trackpad/lightsensor
    and generate SMBIOS Type41 tables for them.
    Add ACPI device for the trackpad to expose the interrupt map
    to the OS so it can be used.
    Configure interrupt GPIOs as PIRQ type and wake GPIOs as
    just standard input type.  The wake GPIO is reconfigured as
    ACPI SCI in the specific device _DSW method.  This prevents
    the wake GPIO from generating a flood of SCI at runtime.
    LTE_WAKE_L_Q and WLAN_WAKE_L_Q are left as ACPI SCI as these
    are not repurposed interrupt pins so they are not generated
    at runtime.
    SIM_DET and ALS_INT_L are set as input since we don't have an
    interrupt handler for them.
    tested on slippy with trackpad with additional
    kernel changes to chromeos_laptop.c to initialize devices.
    1) Ensure trackpad interrupt is functional and that there
    is not a flood of ACPI SCI when trackpad does interrupt:
      9:          1          0          0          0   IO-APIC-fasteoi   acpi
     37:        421          0          0          0   IO-APIC-fasteoi   cyapa
    2) Ensure that devices are exposed as wake capable:
    Device  S-state   Status   Sysfs node
    TPAD      S3    *enabled   pnp:00:00
    TSCR      S3    *disabled  pnp:00:01
    3) Ensure that trackpad can wake from S3 by default, but
    that it does not cause an immediate wake when entering suspend.
    4) Ensure that trackpad can be disabled as a wake source with
    echo TPAD > /proc/acpi/wakeup
    Change-Id: Id562d20b54eeefec56040b8f70ef238911312628
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Reviewed-on: https://gerrit.chromium.org/gerrit/56622
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: http://review.coreboot.org/4190
    Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>
    Tested-by: Stefan Reinauer <stefan.reinauer at coreboot.org>

See http://review.coreboot.org/4190 for details.


More information about the coreboot-gerrit mailing list