[coreboot-gerrit] Patch merged into coreboot/master: 8f4baec elog: Make sure the elog data structures are initialized in elog_clear.

gerrit at coreboot.org gerrit at coreboot.org
Mon Nov 25 23:06:30 CET 2013


the following patch was just integrated into master:
commit 8f4baece7acc3e0ee2e3f04a181ce51b59ec4667
Author: Gabe Black <gabeblack at google.com>
Date:   Thu Apr 25 17:21:58 2013 -0700

    elog: Make sure the elog data structures are initialized in elog_clear.
    
    If elog_clear is called before other elog functions, for instance if it's
    called through an SMI immediately after the system boots, then the elog data
    structures won't have been set up and the system will go off the deep end.
    This change adds a call to elog_init to elog_clear to make sure things things
    are always initialized before we start using them.
    
    Before this change, this command would cause
    the system to lock up if run immediately after boot:
    
    echo 1 > /sys/firmware/gsmi/clear_eventlog
    
    After this change, that results in the log being cleared correctly.
    
    Change-Id: I45027f0dbfa40ca8c581954a93b14b4fedce91ed
    Signed-off-by: Gabe Black <gabeblack at google.com>
    Reviewed-on: https://gerrit.chromium.org/gerrit/49303
    Reviewed-by: Duncan Laurie <dlaurie at chromium.org>
    Reviewed-by: Stefan Reinauer <reinauer at google.com>
    Commit-Queue: Gabe Black <gabeblack at chromium.org>
    Tested-by: Gabe Black <gabeblack at chromium.org>
    Reviewed-on: http://review.coreboot.org/4144
    Tested-by: build bot (Jenkins)
    Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>


See http://review.coreboot.org/4144 for details.

-gerrit



More information about the coreboot-gerrit mailing list