[coreboot-gerrit] New patch to review for coreboot: 3ec1675 slippy/falco/peppy: Fix Chrome OS GPIO export in ACPI
Stefan Reinauer (stefan.reinauer@coreboot.org)
gerrit at coreboot.org
Wed Nov 20 01:33:12 CET 2013
Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4221
-gerrit
commit 3ec1675208c1edd23d0adefc889155f61990bf36
Author: Duncan Laurie <dlaurie at chromium.org>
Date: Tue Jun 4 10:06:25 2013 -0700
slippy/falco/peppy: Fix Chrome OS GPIO export in ACPI
The OIPG package needs to have >1 member to make the chromeos_acpi
kernel driver do the right automagic sysfs topology creation.
Additionally an "unimplemented" GPIO should be reported as 0xFF
because 0 is a valid GPIO number.
verify crossystem on slippy
$ sudo crossystem | grep -e recoverysw_cur -e wpsw_cur
recoverysw_cur = (error)
wpsw_cur = 1
Change-Id: I06dff09152bde30a3ffe58b1defe9d299155472c
Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/57471
Reviewed-by: Aaron Durbin <adurbin at chromium.org>
---
src/mainboard/google/falco/acpi/chromeos.asl | 3 +--
src/mainboard/google/peppy/acpi/chromeos.asl | 3 +--
src/mainboard/google/slippy/acpi/chromeos.asl | 3 +--
3 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/src/mainboard/google/falco/acpi/chromeos.asl b/src/mainboard/google/falco/acpi/chromeos.asl
index e427821..4e9035b 100644
--- a/src/mainboard/google/falco/acpi/chromeos.asl
+++ b/src/mainboard/google/falco/acpi/chromeos.asl
@@ -18,7 +18,6 @@
*/
Name(OIPG, Package() {
- // This GPIO is not available but the package cannot be empty
- Package () { 0x0001, 0, 0, "LynxPoint" }, // recovery
+ Package () { 0x0001, 0, 0xFFFFFFFF, "LynxPoint" }, // no recovery button
Package () { 0x0003, 1, 58, "LynxPoint" }, // firmware write protect
})
diff --git a/src/mainboard/google/peppy/acpi/chromeos.asl b/src/mainboard/google/peppy/acpi/chromeos.asl
index e427821..4e9035b 100644
--- a/src/mainboard/google/peppy/acpi/chromeos.asl
+++ b/src/mainboard/google/peppy/acpi/chromeos.asl
@@ -18,7 +18,6 @@
*/
Name(OIPG, Package() {
- // This GPIO is not available but the package cannot be empty
- Package () { 0x0001, 0, 0, "LynxPoint" }, // recovery
+ Package () { 0x0001, 0, 0xFFFFFFFF, "LynxPoint" }, // no recovery button
Package () { 0x0003, 1, 58, "LynxPoint" }, // firmware write protect
})
diff --git a/src/mainboard/google/slippy/acpi/chromeos.asl b/src/mainboard/google/slippy/acpi/chromeos.asl
index e427821..4e9035b 100644
--- a/src/mainboard/google/slippy/acpi/chromeos.asl
+++ b/src/mainboard/google/slippy/acpi/chromeos.asl
@@ -18,7 +18,6 @@
*/
Name(OIPG, Package() {
- // This GPIO is not available but the package cannot be empty
- Package () { 0x0001, 0, 0, "LynxPoint" }, // recovery
+ Package () { 0x0001, 0, 0xFFFFFFFF, "LynxPoint" }, // no recovery button
Package () { 0x0003, 1, 58, "LynxPoint" }, // firmware write protect
})
More information about the coreboot-gerrit
mailing list