[coreboot-gerrit] New patch to review for coreboot: 050c11a haswell: Update ChromeOS ACPI GPIO package

[Stefan Reinauer (stefan.reinauer@coreboot.org)]

Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4162

-gerrit

commit 050c11a424056497f9f1b6e6e0e93d1321feda04
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Tue May 7 11:31:33 2013 -0700

    haswell: Update ChromeOS ACPI GPIO package
    
    The chromeos_acpi driver sysfs naming is not what
    crossystem expects if there is just one entry in the package
    because it does not add a ".#" suffix in that case.
    
    Specify all the expected GPIOs on wtm2 as undefined, which
    should be 0xFF and not 0x00 becuase 0 is a valid GPIO.
    
    Change-Id: I9b17e9bab94219695e65b17914c84acf02a0983b
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Reviewed-on: https://gerrit.chromium.org/gerrit/50337
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>
---
 src/mainboard/intel/baskingridge/acpi/chromeos.asl | 6 +++---
 src/mainboard/intel/wtm2/acpi/chromeos.asl         | 5 +++--
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/mainboard/intel/baskingridge/acpi/chromeos.asl b/src/mainboard/intel/baskingridge/acpi/chromeos.asl
index 307e2e2..da4fb40 100644
--- a/src/mainboard/intel/baskingridge/acpi/chromeos.asl
+++ b/src/mainboard/intel/baskingridge/acpi/chromeos.asl
@@ -18,7 +18,7 @@
  */
 
 Name(OIPG, Package() {
-	Package() { 0x001, 0, 22, "CougarPoint" }, // recovery button
-	Package() { 0x002, 1, 57, "CougarPoint" }, // developer switch
-	Package() { 0x003, 0, 48, "CougarPoint" }, // firmware write protect
+	Package () { 0x0001, 1, 69, "LynxPoint" }, // recovery
+	Package () { 0x0002, 0, 48, "LynxPoint" }, // developer
+	Package () { 0x0003, 0, 22, "LynxPoint" }, // firmware write protect
 })
diff --git a/src/mainboard/intel/wtm2/acpi/chromeos.asl b/src/mainboard/intel/wtm2/acpi/chromeos.asl
index c6b258b..40ffcf0 100644
--- a/src/mainboard/intel/wtm2/acpi/chromeos.asl
+++ b/src/mainboard/intel/wtm2/acpi/chromeos.asl
@@ -18,6 +18,7 @@
  */
 
 Name(OIPG, Package() {
-	// This GPIO is not available but the package cannot be empty
-	Package () { 0x0001, 0, 0, "LynxPoint" }, // recovery
+	Package () { 0x0001, 0, 0xFF, "LynxPoint" }, // recovery
+	Package () { 0x0002, 0, 0xFF, "LynxPoint" }, // developer
+	Package () { 0x0003, 0, 0xFF, "LynxPoint" }, // firmware write protect
 })