[coreboot-gerrit] Patch set updated for coreboot: c98fa41 ec/lenovo/h8: Enable devices by default

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Wed Nov 13 23:36:11 CET 2013


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4054

-gerrit

commit c98fa4120a8e0ac0df41415195a0bd6f276814a7
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date:   Wed Nov 13 18:31:24 2013 +0100

    ec/lenovo/h8: Enable devices by default
    
    Currently H8 skips important init if it is unable to access CMOS config.
    Change the defaults to enable all features to have a sane system when
    using a system without CMOS config.
    
    Change-Id: I94f39d9d2b4044d60f0cd7b7700bc8629e99201c
    Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
 src/ec/lenovo/h8/h8.c | 22 ++++++++++++----------
 1 file changed, 12 insertions(+), 10 deletions(-)

diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c
index efbb907..62b9f4b 100644
--- a/src/ec/lenovo/h8/h8.c
+++ b/src/ec/lenovo/h8/h8.c
@@ -158,19 +158,21 @@ static void h8_enable(device_t dev)
 	if (!get_option(&val, "volume"))
 		ec_write(H8_VOLUME_CONTROL, val);
 
-
-	if (!get_option(&val, "bluetooth"))
-		h8_bluetooth_enable(val);
+	if (get_option(&val, "bluetooth"))
+		val = 1;
+	h8_bluetooth_enable(val);
 
 	if (!get_option(&val, "wwan"))
-		h8_wwan_enable(val);
+		val = 1
+	h8_wwan_enable(val);
 
-	if (!get_option(&val, "first_battery")) {
-		tmp = ec_read(H8_CONFIG3);
-		tmp &= ~(1 << 4);
-		tmp |= (val & 1)<< 4;
-		ec_write(H8_CONFIG3, tmp);
-	}
+	if (get_option(&val, "first_battery"))
+		val = 1;
+
+	tmp = ec_read(H8_CONFIG3);
+	tmp &= ~(1 << 4);
+	tmp |= (val & 1) << 4;
+	ec_write(H8_CONFIG3, tmp);
 	h8_set_audio_mute(0);
 }
 



More information about the coreboot-gerrit mailing list