[coreboot-gerrit] Patch merged into coreboot/master: d189229 AMD Llano, Brazos boards: Use `sizeof(var)` to get its size

gerrit at coreboot.org gerrit at coreboot.org
Thu May 30 18:10:46 CEST 2013


the following patch was just integrated into master:
commit d189229b45866105a8f4a8aac44a59774d030f81
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Tue May 14 10:06:47 2013 +0200

    AMD Llano, Brazos boards: Use `sizeof(var)` to get its size
    
    Change `sizeof(type) * n`, where n is the number of array
    elements, to `sizeof(variable)` to directly get the size of the
    variable (struct, array). Determining the size by counting array
    elements is error prone and unnecessary.
    
    Rudolf Marek’s patch »ASUS F2A85-M: Correct and clean up PCIe
    config« [1] contains the same change and is ported over. In
    the commit message Rudolf makes the following comment.
    
    »Not sure why the copy is needed instead of direct reference.
    Maybe it has something to do with CAR?«
    
    Testing on the ASRock E350M1, no regressions were noticed.
    
    [1] http://review.coreboot.org/#/c/3194/
    
    Change-Id: I123031b3819a10c9c85577fdca96c70d9c992e87
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-on: http://review.coreboot.org/3248
    Tested-by: build bot (Jenkins)
    Reviewed-by: Bruce Griffith <Bruce.Griffith at se-eng.com>


See http://review.coreboot.org/3248 for details.

-gerrit



More information about the coreboot-gerrit mailing list