[coreboot-gerrit] Patch set updated for coreboot: fafa0d9 crossgcc/buildgcc: Remove unneeded 'break' statements
Paul Menzel (paulepanter@users.sourceforge.net)
gerrit at coreboot.org
Wed May 29 00:58:39 CEST 2013
Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3330
-gerrit
commit fafa0d90b9b61b852c47110d5ae0788cabb15834
Author: David Hubbard <david.c.hubbard+coreboot at gmail.com>
Date: Tue May 28 16:33:15 2013 -0600
crossgcc/buildgcc: Remove unneeded 'break' statements
Bash case statements are terminated with ';;'.
Unlike C, bash case statements will not continue to the next case. No 'break' is needed.
Change-Id: I62e7e91f3223ac4052728a1ca12a4681af0dc036
Signed-off-by: David Hubbard <david.c.hubbard+coreboot at gmail.com>
---
util/crossgcc/buildgcc | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index c436f8e..1d8e54c 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -215,16 +215,16 @@ while true ; do
-G|--gdb) shift; SKIPGDB=0;;
-S|--scripting) shift; SKIPPYTHON=0;;
-y|--ccache) shift; USECCACHE=1;;
- --) shift; break;;
+ --) shift;;
-*) printf "Invalid option\n\n"; myhelp; exit 1;;
- *) break;;
+ *) ;;
esac
done
case "$TARGETARCH" in
- armv7a-eabi) break;;
- i386-elf) break;;
- i386-mingw32) break;;
+ armv7a-eabi) ;;
+ i386-elf) ;;
+ i386-mingw32) ;;
i386*) TARGETARCH=i386-elf;;
arm*) TARGETARCH=armv7a-eabi;;
*) printf "Invalid architecture\n\n"; myhelp; exit 1;;
More information about the coreboot-gerrit
mailing list