[coreboot-gerrit] New patch to review for filo: f7471b6 Fix random warnings in char_io.c

Nico Huber (nico.huber@secunet.com) gerrit at coreboot.org
Sun May 26 15:20:17 CEST 2013


Nico Huber (nico.huber at secunet.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3294

-gerrit

commit f7471b63091dbad30db257ec49eed0e559033c7a
Author: Nico Huber <nico.huber at secunet.com>
Date:   Sun May 26 12:00:16 2013 +0200

    Fix random warnings in char_io.c
    
    Fix two warnings:
    
    char_io.c: In function 'grub_printf':
    char_io.c:86:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
    
    char_io.c: In function 'init_page':
    char_io.c:104:4: warning: implicit declaration of function 'get_cb_version' [-Wimplicit-function-declaration]
    
    by removing the variable 'ret' and including sys_info.h for the
    'get_cb_version' prototype.
    
    Change-Id: I596b17b3594f8909ff5d6eccb9cb0be475bf052e
    Signed-off-by: Nico Huber <nico.huber at secunet.com>
---
 main/grub/char_io.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/main/grub/char_io.c b/main/grub/char_io.c
index fec3387..21df9f8 100644
--- a/main/grub/char_io.c
+++ b/main/grub/char_io.c
@@ -20,6 +20,7 @@
  */
 
 #include <libpayload.h>
+#include <sys_info.h>
 #include <config.h>
 #include <version.h>
 #include <grub/shared.h>
@@ -83,13 +84,12 @@ void grub_putstr(const char *str)
 
 void grub_printf(const char *format, ...)
 {
-	int ret;
 	va_list args;
 #define OUTPUT_SIZE 256
 	char output[OUTPUT_SIZE];
 
 	va_start(args, format);
-	ret = vsnprintf(output, OUTPUT_SIZE, format, args);
+	vsnprintf(output, OUTPUT_SIZE, format, args);
 	va_end(args);
 	grub_putstr(output);
 	refresh();



More information about the coreboot-gerrit mailing list