[coreboot-gerrit] Patch merged into coreboot/master: 711a6fd Get rid of MAXIMUM_CONSOLE_LOGLEVEL; compile all messages into the coreboot binary
gerrit at coreboot.org
gerrit at coreboot.org
Fri May 10 17:33:50 CEST 2013
the following patch was just integrated into master:
commit 711a6fde0db2f7a0c388fc97faec1013caaa2789
Author: Ronald G. Minnich <rminnich at gmail.com>
Date: Fri May 3 18:25:27 2013 +0200
Get rid of MAXIMUM_CONSOLE_LOGLEVEL; compile all messages into the coreboot binary
This option has never had much if any use. It solved a problem over 10
years ago that resulted from an argument over the value or lack thereof
of including all the debug strings in a coreboot image. The answer is
in: it's a good idea to maintain the capability to print all messages,
for many reasons.
This option is also misleading people, as in a recent discussion, to
believe that log messges are controlled at build time in a way they are
not. For the record, from this day forward, we can print messages at all
log levels and the default log level is set at boot time, as directed by
DEFAULT_CONSOLE_LOGLEVEL. You can set the default to 0 at build time and
if you are having trouble override it in CMOS and get more messages.
Besides, a quick glance shows it's always set to max (9 in this case) in
the very few cases (1) in which it is set.
Change-Id: I60c4cdaf4dcd318b841a6d6c70546417c5626f21
Signed-off-by: Ronald G. Minnich <rminnich at gmail.com>
Reviewed-on: http://review.coreboot.org/3188
Tested-by: build bot (Jenkins)
See http://review.coreboot.org/3188 for details.
-gerrit
More information about the coreboot-gerrit
mailing list