[coreboot-gerrit] Patch set updated for coreboot: dca014e cbfs_core.c: make cfbs searches even less verbose
Paul Menzel (paulepanter@users.sourceforge.net)
gerrit at coreboot.org
Tue May 7 23:40:29 CEST 2013
Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3208
-gerrit
commit dca014e337c76fded0249246afb432eb58836def
Author: Dave Frodin <dave.frodin at se-eng.com>
Date: Mon May 6 15:51:39 2013 -0600
cbfs_core.c: make cfbs searches even less verbose
The cbfs core code would print out the name of the file it is
searching for and when it is found would print out the name
again. This contributes to a lot of unnecessary messages in a
functioning payload’s output. Change this message to a DEBUG one
so that it will only be printed when CONFIG_DEBUG_CBFS is enabled.
Change-Id: Ib238ff174bedba8eaaad8d1d452721fcac339b1a
Signed-off-by: Dave Frodin <dave.frodin at se-eng.com>
---
payloads/libpayload/libcbfs/cbfs_core.c | 6 +++---
src/lib/cbfs_core.c | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/payloads/libpayload/libcbfs/cbfs_core.c b/payloads/libpayload/libcbfs/cbfs_core.c
index 3fe6971..48a4b3a 100644
--- a/payloads/libpayload/libcbfs/cbfs_core.c
+++ b/payloads/libpayload/libcbfs/cbfs_core.c
@@ -123,7 +123,7 @@ struct cbfs_file *cbfs_get_file(struct cbfs_media *media, const char *name)
#endif
DEBUG("CBFS location: 0x%x~0x%x, align: %d\n", offset, romsize, align);
- LOG("Looking for '%s' starting from 0x%x.\n", name, offset);
+ DEBUG("Looking for '%s' starting from 0x%x.\n", name, offset);
media->open(media);
while (offset < romsize &&
media->read(media, &file, offset, sizeof(file)) == sizeof(file)) {
@@ -150,7 +150,7 @@ struct cbfs_file *cbfs_get_file(struct cbfs_media *media, const char *name)
} else if (strcmp(file_name, name) == 0) {
int file_offset = ntohl(file.offset),
file_len = ntohl(file.len);
- LOG("Found file (offset=0x%x, len=%d).\n",
+ DEBUG("Found file (offset=0x%x, len=%d).\n",
offset + file_offset, file_len);
media->unmap(media, file_name);
file_ptr = media->map(media, offset,
@@ -169,7 +169,7 @@ struct cbfs_file *cbfs_get_file(struct cbfs_media *media, const char *name)
offset += align - (offset % align);
}
media->close(media);
- LOG("WARNING: Not found.\n");
+ LOG("WARNING: '%s' not found.\n", name);
return NULL;
}
diff --git a/src/lib/cbfs_core.c b/src/lib/cbfs_core.c
index 1220d48..852b37f 100644
--- a/src/lib/cbfs_core.c
+++ b/src/lib/cbfs_core.c
@@ -123,7 +123,7 @@ struct cbfs_file *cbfs_get_file(struct cbfs_media *media, const char *name)
#endif
DEBUG("CBFS location: 0x%x~0x%x, align: %d\n", offset, romsize, align);
- LOG("Looking for '%s' starting from 0x%x.\n", name, offset);
+ DEBUG("Looking for '%s' starting from 0x%x.\n", name, offset);
media->open(media);
while (offset < romsize &&
media->read(media, &file, offset, sizeof(file)) == sizeof(file)) {
@@ -150,7 +150,7 @@ struct cbfs_file *cbfs_get_file(struct cbfs_media *media, const char *name)
} else if (strcmp(file_name, name) == 0) {
int file_offset = ntohl(file.offset),
file_len = ntohl(file.len);
- LOG("Found file (offset=0x%x, len=%d).\n",
+ DEBUG("Found file (offset=0x%x, len=%d).\n",
offset + file_offset, file_len);
media->unmap(media, file_name);
file_ptr = media->map(media, offset,
@@ -169,7 +169,7 @@ struct cbfs_file *cbfs_get_file(struct cbfs_media *media, const char *name)
offset += align - (offset % align);
}
media->close(media);
- LOG("WARNING: Not found.\n");
+ LOG("WARNING: '%s' not found.\n", name);
return NULL;
}
More information about the coreboot-gerrit
mailing list