[coreboot-gerrit] Patch merged into coreboot/master: ac75bc6 x86 I/O APIC: Make functions `io_apic_{read, write}()` public
gerrit at coreboot.org
gerrit at coreboot.org
Tue May 7 22:40:17 CEST 2013
the following patch was just integrated into master:
commit ac75bc682b2c546ea01d6ad254df7b1a48a9f68f
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date: Tue Apr 23 14:34:43 2013 +0200
x86 I/O APIC: Make functions `io_apic_{read,write}()` public
Some LPC initialiation can save some lines of code when being able
to use the functions `io_apic_read()` and `io_apic_write()`.
As these two functions are now public, remove them from the generic
driver as otherwise we get a build errors like the following.
[…]
Building roda/rk9; i386: ok, using i386-elf-gcc
Using payload /srv/jenkins/payloads/seabios/bios.bin.elf
Creating config file... (blobs, ccache) ok; Compiling image on 4 cpus in parallel .. FAILED after 12s!
Log excerpt:
coreboot-builds/roda_rk9/arch/x86/lib/ramstage.o: In function `io_apic_write':
/srv/jenkins/.jenkins/jobs/coreboot-gerrit/workspace/src/arch/x86/lib/ioapic.c:32: multiple definition of `io_apic_write'
coreboot-builds/roda_rk9/drivers/generic/ioapic/ramstage.o:/srv/jenkins/.jenkins/jobs/coreboot-gerrit/workspace/src/drivers/generic/ioapic/ioapic.c:22: first defined here
collect2: error: ld returned 1 exit status
make: *** [coreboot-builds/roda_rk9/generated/coreboot_ram.o] Error 1
make: *** Waiting for unfinished jobs....
[…]
Change-Id: Id600007573ff011576967339cc66e6c883a2ed5a
Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
Reviewed-on: http://review.coreboot.org/3180
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin at google.com>
Build-Tested: build bot (Jenkins) at Sun May 5 02:36:09 2013, giving +1
Reviewed-By: Aaron Durbin <adurbin at google.com> at Tue May 7 20:01:50 2013, giving +2
See http://review.coreboot.org/3180 for details.
-gerrit
More information about the coreboot-gerrit
mailing list