[coreboot-gerrit] New patch to review for coreboot: a050af7 x86: use asmlinkage macro for smm_handler_t

Aaron Durbin (adurbin@google.com) gerrit at coreboot.org
Tue May 7 19:59:45 CEST 2013


Aaron Durbin (adurbin at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3215

-gerrit

commit a050af7f446281f87a387040cac6e6b0e336de2f
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Tue May 7 12:58:12 2013 -0500

    x86: use asmlinkage macro for smm_handler_t
    
    The smm_handler_t type was added before the introduction
    of the asmlinkage macro. Now that asmlinkage is available
    use it.
    
    Change-Id: I85ec72cf958bf4b77513a85faf6d300c781af603
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
 src/include/cpu/x86/smm.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/include/cpu/x86/smm.h b/src/include/cpu/x86/smm.h
index 62494a9..df7e3de 100644
--- a/src/include/cpu/x86/smm.h
+++ b/src/include/cpu/x86/smm.h
@@ -33,6 +33,7 @@
 #define SMM_ENTRY_OFFSET 0x8000
 #define SMM_SAVE_STATE_BEGIN(x) (SMM_ENTRY_OFFSET + (x))
 
+#include <arch/cpu.h>
 #include <types.h>
 typedef struct {
 	u16	es_selector;
@@ -429,8 +430,8 @@ struct smm_runtime {
 	u8 apic_id_to_cpu[CONFIG_MAX_CPUS];
 } __attribute__ ((packed));
 
-typedef void __attribute__((cdecl)) (*smm_handler_t)(void *arg, int cpu,
-                              const struct smm_runtime *runtime);
+typedef void asmlinkage (*smm_handler_t)(void *arg, int cpu,
+                                         const struct smm_runtime *runtime);
 
 #ifdef __SMM__
 /* SMM Runtime helpers. */



More information about the coreboot-gerrit mailing list