[coreboot-gerrit] Patch merged into coreboot/master: 935850e asrock/e350m1: reduce default stack size

gerrit at coreboot.org gerrit at coreboot.org
Tue May 7 18:30:46 CEST 2013


the following patch was just integrated into master:
commit 935850e08293cec1cb27d12358b27285e780566a
Author: Stefan Reinauer <reinauer at chromium.org>
Date:   Mon May 6 16:16:03 2013 -0700

    asrock/e350m1: reduce default stack size
    
    The stack used on the ASRock E350M1 is significantly less than
    what we currently set (64k per core). In fact, we use about half
    of the default stack size (4k) on core 0 and even less on non
    BSP cores [1]:
    
        $ grep stack coreboot_without_patch_but_monotonic_timer.log
        CPU1: stack_base 002a0000, stack_end 002afff8
        CPU1: stack: 002a0000 - 002b0000, lowest used address 002afda8, stack used: 600 bytes
        CPU0: stack: 002b0000 - 002c0000, lowest used address 002bf75c, stack used: 2212 bytes
    
    Removing the Kconfig variable STACK_SIZE to use the default results
    in the following numbers of stack usage.
    
        $ grep stack coreboot_with_patch.log
        CPU1: stack_base 00287000, stack_end 00287ff8
        CPU1: stack: 00287000 - 00288000, lowest used address 00287da8, stack used: 600 bytes
        CPU0: stack: 00288000 - 00289000, lowest used address 0028875c, stack used: 2212 bytes
    
    [1] http://review.coreboot.org/#/c/3154/
        (comment May 2 10:21 AM)
    
    Change-Id: Ibdb2102c86094fce3787e3b5a162ca8423de205c
    Signed-off-by: Stefan Reinauer <reinauer at google.com>
    Tested-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-on: http://review.coreboot.org/3209
    Tested-by: build bot (Jenkins)
    Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>

Build-Tested: build bot (Jenkins) at Tue May  7 17:58:08 2013, giving +1
Reviewed-By: Ronald G. Minnich <rminnich at gmail.com> at Tue May  7 18:30:43 2013, giving +2
See http://review.coreboot.org/3209 for details.

-gerrit



More information about the coreboot-gerrit mailing list