[coreboot-gerrit] New patch to review for coreboot: 8c8f462 AMD Hudson/Fam15tn: Declare codec arrays as `static`

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Sat May 4 18:30:55 CEST 2013


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3198

-gerrit

commit 8c8f4622eaba426b1263dc92170177a8a1a4f12d
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Sat May 4 18:21:17 2013 +0200

    AMD Hudson/Fam15tn: Declare codec arrays as `static`
    
    These arrays are declared as `static` for AMD SB800 based boards,
    so do the same for this generation.
    
    Rudolf Marek just changed `const CODEC_TBL_LIST` to `static const`
    in [1]. Adapt all boards to this change to keep the differences
    between them small.
    
    [1] http://review.coreboot.org/#/c/3170/3/src/mainboard/asus/f2a85-m/BiosCallOuts.c
    
    Change-Id: I353b38bd8bc77ba500a4b7fe9250e9aa3071c530
    Signed-off-by: Rudolf Marek <r.marek at assembler.cz>
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 src/mainboard/amd/parmer/BiosCallOuts.c   | 4 ++--
 src/mainboard/amd/thatcher/BiosCallOuts.c | 4 ++--
 src/mainboard/asus/f2a85-m/BiosCallOuts.c | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/mainboard/amd/parmer/BiosCallOuts.c b/src/mainboard/amd/parmer/BiosCallOuts.c
index c77d78d..9592c9d 100644
--- a/src/mainboard/amd/parmer/BiosCallOuts.c
+++ b/src/mainboard/amd/parmer/BiosCallOuts.c
@@ -65,7 +65,7 @@ AGESA_STATUS GetBiosCallout (UINT32 Func, UINT32 Data, VOID *ConfigPtr)
 /**
  * AMD Parmer Platform ALC272 Verb Table
  */
-const CODEC_ENTRY Parmer_Alc272_VerbTbl[] = {
+static const CODEC_ENTRY Parmer_Alc272_VerbTbl[] = {
 	{0x11, 0x411111F0},
 	{0x12, 0x411111F0},
 	{0x13, 0x411111F0},
@@ -83,7 +83,7 @@ const CODEC_ENTRY Parmer_Alc272_VerbTbl[] = {
 	{0xff, 0xffffffff}
 };
 
-const CODEC_TBL_LIST ParmerCodecTableList[] =
+static const CODEC_TBL_LIST ParmerCodecTableList[] =
 {
 	{0x10ec0272, (CODEC_ENTRY*)&Parmer_Alc272_VerbTbl[0]},
 	{(UINT32)0x0FFFFFFFF, (CODEC_ENTRY*)0x0FFFFFFFFUL}
diff --git a/src/mainboard/amd/thatcher/BiosCallOuts.c b/src/mainboard/amd/thatcher/BiosCallOuts.c
index 9a3f61c..6979522 100644
--- a/src/mainboard/amd/thatcher/BiosCallOuts.c
+++ b/src/mainboard/amd/thatcher/BiosCallOuts.c
@@ -65,7 +65,7 @@ AGESA_STATUS GetBiosCallout (UINT32 Func, UINT32 Data, VOID *ConfigPtr)
 /**
  * AMD Thatcher Platform ALC272 Verb Table
  */
-const CODEC_ENTRY Thatcher_Alc272_VerbTbl[] = {
+static const CODEC_ENTRY Thatcher_Alc272_VerbTbl[] = {
 	{0x11, 0x411111F0},
 	{0x12, 0x411111F0},
 	{0x13, 0x411111F0},
@@ -83,7 +83,7 @@ const CODEC_ENTRY Thatcher_Alc272_VerbTbl[] = {
 	{0xff, 0xffffffff}
 };
 
-const CODEC_TBL_LIST ThatcherCodecTableList[] =
+static const CODEC_TBL_LIST ThatcherCodecTableList[] =
 {
 	{0x10ec0272, (CODEC_ENTRY*)&Thatcher_Alc272_VerbTbl[0]},
 	{(UINT32)0x0FFFFFFFF, (CODEC_ENTRY*)0x0FFFFFFFFUL}
diff --git a/src/mainboard/asus/f2a85-m/BiosCallOuts.c b/src/mainboard/asus/f2a85-m/BiosCallOuts.c
index f976001..e913896 100644
--- a/src/mainboard/asus/f2a85-m/BiosCallOuts.c
+++ b/src/mainboard/asus/f2a85-m/BiosCallOuts.c
@@ -65,7 +65,7 @@ AGESA_STATUS GetBiosCallout (UINT32 Func, UINT32 Data, VOID *ConfigPtr)
 /**
  * AMD Thatcher Platform ALC272 Verb Table
  */
-const CODEC_ENTRY Thatcher_Alc272_VerbTbl[] = {
+static const CODEC_ENTRY Thatcher_Alc272_VerbTbl[] = {
 	{0x11, 0x411111F0},
 	{0x12, 0x411111F0},
 	{0x13, 0x411111F0},
@@ -83,7 +83,7 @@ const CODEC_ENTRY Thatcher_Alc272_VerbTbl[] = {
 	{0xff, 0xffffffff}
 };
 
-const CODEC_TBL_LIST ThatcherCodecTableList[] =
+static const CODEC_TBL_LIST ThatcherCodecTableList[] =
 {
 	{0x10ec0272, (CODEC_ENTRY*)&Thatcher_Alc272_VerbTbl[0]},
 	{(UINT32)0x0FFFFFFFF, (CODEC_ENTRY*)0x0FFFFFFFFUL}



More information about the coreboot-gerrit mailing list