[coreboot-gerrit] New patch to review for coreboot: 2c38317 armv7: remove loop from dcache_mmu_disable()

David Hendricks (dhendrix@chromium.org) gerrit at coreboot.org
Fri Mar 29 21:42:41 CET 2013


David Hendricks (dhendrix at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2967

-gerrit

commit 2c38317a9105ccc6b4183e2a839fefe1b7fb5ad2
Author: David Hendricks <dhendrix at chromium.org>
Date:   Fri Mar 29 13:40:09 2013 -0700

    armv7: remove loop from dcache_mmu_disable()
    
    dcache_mmu_disable() no longer needs to have its own iterative loop
    to select each cache level of cache since
    dcache_clean_invalidate_all() does that now.
    
    Change-Id: I5ca273f98943981b943c1c1622f4574d7133fb50
    Signed-off-by: David Hendricks <dhendrix at chromium.org>
---
 src/arch/armv7/lib/cache.c | 32 ++------------------------------
 1 file changed, 2 insertions(+), 30 deletions(-)

diff --git a/src/arch/armv7/lib/cache.c b/src/arch/armv7/lib/cache.c
index c7283f1..04eaa88 100644
--- a/src/arch/armv7/lib/cache.c
+++ b/src/arch/armv7/lib/cache.c
@@ -237,37 +237,9 @@ void dcache_clean_invalidate_by_mva(unsigned long addr, unsigned long len)
 
 void dcache_mmu_disable(void)
 {
-	uint32_t sctlr, clidr;
-	int level;
-
-	clidr = read_clidr();
-	for (level = 0; level < 7; level++) {
-		unsigned int ctype = (clidr >> (level * 3)) & 0x7;
-		uint32_t csselr;
-
-		switch(ctype) {
-		case 0x0:
-			/* no cache */
-			break;
-		case 0x2:
-		case 0x4:
-			/* dcache only or unified cache */
-			csselr = level << 1;
-			write_csselr(csselr);
-			dcache_clean_invalidate_all();
-			break;
-		case 0x3:
-			/* separate icache and dcache */
-			csselr = level << 1;
-			write_csselr(csselr);
-			dcache_clean_invalidate_all();
-			break;
-		default:
-			/* reserved */
-			break;
-		}
-	}
+	uint32_t sctlr;
 
+	dcache_clean_invalidate_all();
 	sctlr = read_sctlr();
 	sctlr &= ~(SCTLR_C | SCTLR_M);
 	write_sctlr(sctlr);



More information about the coreboot-gerrit mailing list