[coreboot-gerrit] Patch merged into coreboot/master: 5d74156 AMD Inagua: broadcom.c: Add missing prototype for `broadcom_init()`

gerrit at coreboot.org gerrit at coreboot.org
Fri Mar 29 21:10:50 CET 2013

the following patch was just integrated into master:
commit 5d7415673f93ddac743de71fb2272fccdd7300fb
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Fri Mar 29 11:07:22 2013 +0100

    AMD Inagua: broadcom.c: Add missing prototype for `broadcom_init()`
    Building the AMD Inagua board, the following warning is thrown.
            CC         mainboard/amd/inagua/get_bus_conf.ramstage.o
        src/mainboard/amd/inagua/broadcom.c:319:6: warning: no previous prototype for 'broadcom_init' [-Wmissing-prototypes]
    This warning was introduced by commit 3926b4c5.
        commit 3926b4c520e74da9dc22e3d136a8a178483e0d25
        Author: Jens Rottmann <JRottmann at LiPPERTembedded.de>
        Date:   Fri Mar 1 19:41:41 2013 +0100
            AMD Inagua: add GEC firmware, document Broadcom BCM57xx Selfboot Patch format
            Reviewed-on: http://review.coreboot.org/2831
    Adding the prototype to `broadcom.c` and removing it from
    `mainboard.c` fixes the warning.
    Change-Id: I1da0c4e972e129047dd8230d573f1c43fd71eb20
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-on: http://review.coreboot.org/2952
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>

Build-Tested: build bot (Jenkins) at Fri Mar 29 11:36:26 2013, giving +1
Reviewed-By: Stefan Reinauer <stefan.reinauer at coreboot.org> at Fri Mar 29 21:10:34 2013, giving +2
See http://review.coreboot.org/2952 for details.


More information about the coreboot-gerrit mailing list