[coreboot-gerrit] New patch to review for coreboot: 7084845 ASRock E350M1: mptable.c: Remove unused variable `dev`

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Fri Mar 29 20:55:18 CET 2013

Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2965


commit 7084845e22d2e5630b19bda8c3412dc78bb78901
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Fri Mar 29 20:37:42 2013 +0100

    ASRock E350M1: mptable.c: Remove unused variable `dev`
    When building the ASRock E350M1, the following warning is shown.
        $ make # on Jenkins (build server)
            CC         mainboard/asrock/e350m1/mptable.ramstage.o
        src/mainboard/asrock/e350m1/mptable.c:64:12: warning: unused variable 'dev' [-Wunused-variable]
    Removing the variable `dev` addresses the warning.
    The same change was done in the following commit for the
    AMD Persimmon board.
        commit d7a696d0f229abccc95ff411f28d91b9b796ab74
        Author: efdesign98 <efdesign98 at gmail.com>
        Date:   Thu Sep 15 15:24:26 2011 -0600
            Persimmon updates for AMD F14 rev C0
            Reviewed-on: http://review.coreboot.org/137
    Change-Id: I83f4630cb6ab1e4c95d04b4e8423850ed1858e45
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
 src/mainboard/asrock/e350m1/mptable.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/mainboard/asrock/e350m1/mptable.c b/src/mainboard/asrock/e350m1/mptable.c
index 360c5c0..f0e9545 100644
--- a/src/mainboard/asrock/e350m1/mptable.c
+++ b/src/mainboard/asrock/e350m1/mptable.c
@@ -61,7 +61,6 @@ static void *smp_write_config_table(void *v)
   /* I/O APICs:   APIC ID Version State   Address */
-  device_t dev;
   u32 dword;
   u8 byte;

More information about the coreboot-gerrit mailing list