[coreboot-gerrit] Patch merged into coreboot/master: 0135702 x86: mark .textfirst as allocatable and executable

gerrit at coreboot.org gerrit at coreboot.org
Sat Mar 23 19:38:54 CET 2013

the following patch was just integrated into master:
commit 0135702802601c19937eec57513f3a6e2f4d1e00
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Fri Mar 22 20:23:17 2013 -0500

    x86: mark .textfirst as allocatable and executable
    When the linking of ramstage was changed to use an intermeidate
    object with all ramstage objects in it the .textfirst section
    was introduced to keep the entry point at 0. However, the
    section was not marked allocatable or executable. Nor was it
    marked as @progbits. That didn't cause an issue on its own since
    .textfirst was directly called out in the linker script. However,
    the rmodule infrastructure relies on all the relocation entries
    being included in the rmodule. Without the proper section attributes
    the .rel.textfirst section entries were not being included in
    the final ramstage rmodule.
    Change-Id: I54e7055a19bee6c86e269eba047d9a560702afde
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: http://review.coreboot.org/2885
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>

Build-Tested: build bot (Jenkins) at Sat Mar 23 04:05:02 2013, giving +1
Reviewed-By: Stefan Reinauer <stefan.reinauer at coreboot.org> at Sat Mar 23 19:38:52 2013, giving +2
See http://review.coreboot.org/2885 for details.


More information about the coreboot-gerrit mailing list