[coreboot-gerrit] New patch to review for coreboot: 5e820ed x86: expose console_tx_flush in romstage

Aaron Durbin (adurbin@google.com) gerrit at coreboot.org
Sat Mar 23 02:27:48 CET 2013

Aaron Durbin (adurbin at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2882


commit 5e820ed5a7abda5b1d568fc6db14150ac7627da3
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Fri Mar 22 19:52:42 2013 -0500

    x86: expose console_tx_flush in romstage
    The vboot module relied on being able to flush the console
    after it called vtxprintf() from its log wrapper function.
    Expose the console_tx_flush() function in romstage so the
    vboot module can ensure messages are flushed.
    Change-Id: I578053df4b88c2068bd9cc90eea5573069a0a4e8
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
 src/arch/x86/lib/romstage_console.c | 2 +-
 src/include/console/console.h       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/arch/x86/lib/romstage_console.c b/src/arch/x86/lib/romstage_console.c
index f43db05..f53f5a9 100644
--- a/src/arch/x86/lib/romstage_console.c
+++ b/src/arch/x86/lib/romstage_console.c
@@ -54,7 +54,7 @@ void console_tx_byte(unsigned char byte)
-static void console_tx_flush(void)
+void console_tx_flush(void)
 	uart8250_mem_tx_flush(CONFIG_OXFORD_OXPCIE_BASE_ADDRESS + 0x1000);
diff --git a/src/include/console/console.h b/src/include/console/console.h
index 496571b..0b63644 100644
--- a/src/include/console/console.h
+++ b/src/include/console/console.h
@@ -38,7 +38,6 @@
 #ifndef __PRE_RAM__
-void console_tx_flush(void);
 unsigned char console_rx_byte(void);
 int console_tst_byte(void);
 struct console_driver {
@@ -68,6 +67,7 @@ extern int console_loglevel;
 #ifndef __ROMCC__
 void console_init(void);
 void console_tx_byte(unsigned char byte);
+void console_tx_flush(void);
 void post_code(u8 value);
 /* this function is weak and can be overridden by a mainboard function. */
 void mainboard_post(u8 value);

More information about the coreboot-gerrit mailing list