[coreboot-gerrit] New patch to review for coreboot: 0c69374 armv7: remove old isb() and dsb() macros

David Hendricks (dhendrix@chromium.org) gerrit at coreboot.org
Wed Mar 20 22:48:15 CET 2013


David Hendricks (dhendrix at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2868

-gerrit

commit 0c69374f0b2b0db89e1ba7bb1d859c808cef4be0
Author: David Hendricks <dhendrix at chromium.org>
Date:   Tue Mar 19 17:12:46 2013 -0700

    armv7: remove old isb() and dsb() macros
    
    This removes some old macros that we no longer use.
    
    Change-Id: I9d87beb5c2deca228cdf89a98e54b2779be0f0ea
    Signed-off-by: David Hendricks <dhendrix at chromium.org>
---
 src/arch/armv7/include/arch/io.h | 1 -
 src/arch/armv7/include/system.h  | 3 ---
 2 files changed, 4 deletions(-)

diff --git a/src/arch/armv7/include/arch/io.h b/src/arch/armv7/include/arch/io.h
index 623c305..b99e014 100644
--- a/src/arch/armv7/include/arch/io.h
+++ b/src/arch/armv7/include/arch/io.h
@@ -97,7 +97,6 @@ extern inline void __raw_readsl(unsigned int addr, void *data, int longlen)
  * TODO: The kernel offers some more advanced versions of barriers, it might
  * have some advantages to use them instead of the simple one here.
  */
-//#define dmb()		__asm__ __volatile__ ("" : : : "memory")
 #define __iormb()	dmb()
 #define __iowmb()	dmb()
 
diff --git a/src/arch/armv7/include/system.h b/src/arch/armv7/include/system.h
index f3e9b6b..eda0bc1 100644
--- a/src/arch/armv7/include/system.h
+++ b/src/arch/armv7/include/system.h
@@ -43,9 +43,6 @@
  */
 #define __asmeq(x, y)  ".ifnc " x "," y " ; .err ; .endif\n\t"
 
-/* FIXME: conflicts with new implementation in cache.c */
-//#define isb() __asm__ __volatile__ ("" : : : "memory")
-
 #define nop() __asm__ __volatile__("mov\tr0,r0\t@ nop\n\t");
 
 #define arch_align_stack(x) (x)



More information about the coreboot-gerrit mailing list