[coreboot-gerrit] Patch merged into coreboot/master: 99b024d bd82x6x: Fix early USB BAR programming (finally?)

gerrit at coreboot.org gerrit at coreboot.org
Tue Jun 25 18:50:56 CEST 2013


the following patch was just integrated into master:
commit 99b024db885833ebe46be0917f9c2283e3778fac
Author: Nico Huber <nico.huber at secunet.com>
Date:   Mon Jun 24 12:39:53 2013 +0200

    bd82x6x: Fix early USB BAR programming (finally?)
    
    The xHCI controller's MMIO space has a length of 64KiB not 4KiB.
    Therefore, setting the xHCI BAR to 0xe8001000 worked the same like
    setting it to 0xe8000000, as bit12 is reserved and ignored. This again
    interfered with the MMIO space of the first EHCI controller and broke
    S3 resume on Ivy Bridge.
    
    AFAIK, the MRC ignores the setting of the xHCI BAR, anyway. So just drop
    these lines.
    
    Change-Id: I8af9c2ba34133f15636a9056fc8880b3b6ab95e0
    Signed-off-by: Nico Huber <nico.huber at secunet.com>
    Reviewed-on: http://review.coreboot.org/3521
    Tested-by: build bot (Jenkins)
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-by: Marc Jones <marc.jones at se-eng.com>


See http://review.coreboot.org/3521 for details.

-gerrit



More information about the coreboot-gerrit mailing list