[coreboot-gerrit] New patch to review for coreboot: 6da9525 libpayload: Use longer delay in tinycurses' wgetch()

Nico Huber (nico.huber@secunet.com) gerrit at coreboot.org
Tue Jun 25 15:36:18 CEST 2013


Nico Huber (nico.huber at secunet.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3533

-gerrit

commit 6da952553dad9b9c591bd23b6e9c6c4720ca40b5
Author: Nico Huber <nico.huber at secunet.com>
Date:   Tue Jun 25 15:19:48 2013 +0200

    libpayload: Use longer delay in tinycurses' wgetch()
    
    The counted delay of 1ms was shorter than the time usb_poll() took
    (~30ms observed). So with a given timeout of 100ms it actually took 3s.
    We can lower the problem if we delay 10ms per loop iteration.
    
    Change-Id: I6e084bdd05332111cc8adcd13493a5dfb4bc8b28
    Signed-off-by: Nico Huber <nico.huber at secunet.com>
---
 3rdparty                              |  2 +-
 payloads/libpayload/curses/keyboard.c | 14 +++++++-------
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/3rdparty b/3rdparty
index ba8caa3..e934f70 160000
--- a/3rdparty
+++ b/3rdparty
@@ -1 +1 @@
-Subproject commit ba8caa30bd5ed6d89dbfd40e17c75c94d43804c6
+Subproject commit e934f70a1a1b06a11ee061c7988c405b1ea5f1ef
diff --git a/payloads/libpayload/curses/keyboard.c b/payloads/libpayload/curses/keyboard.c
index 7ebb04f..9648dde 100644
--- a/payloads/libpayload/curses/keyboard.c
+++ b/payloads/libpayload/curses/keyboard.c
@@ -175,15 +175,15 @@ static int curses_getchar(int _delay)
 		}
 #endif
 
-		if (_delay == 0)
+		if (_delay == 0) {
 			break;
-
-		if (_delay > 0) {
-			mdelay(1);
-			_delay--;
+		} else if (_delay >= 10) {
+			mdelay(10);
+			_delay -= 10;
+		} else if (_delay > 0) {
+			mdelay(_delay);
+			_delay = 0;
 		}
-
-
 	} while (1);
 
 	return ERR;



More information about the coreboot-gerrit mailing list