[coreboot-gerrit] Patch merged into coreboot/master: cacc58a winbond/w83627dhg: Correct resource setting for SPI (LDN6)

gerrit at coreboot.org gerrit at coreboot.org
Tue Jun 18 19:15:13 CEST 2013


the following patch was just integrated into master:
commit cacc58a874092bbbd680cd636ed840c1844c84a1
Author: Nico Huber <nico.huber at secunet.com>
Date:   Tue May 14 15:25:26 2013 +0200

    winbond/w83627dhg: Correct resource setting for SPI (LDN6)
    
    The SPI logical device on the W83627DHG uses the second i/o port
    register pair but not the first one. So we have to also set `io1`
    (the second io_info struct) and not `io0` in the pnp_info structure.
    
    Setting the PNP_IO1 flag without a mask in `io1` caused coreboot to
    hang in pnp_enable_devices() until commit aeead274 which added a
    check for an unset mask.
    
    Change-Id: I027d279b4641fecd88afb14d40fbe1c0bfbf81bb
    Signed-off-by: Nico Huber <nico.huber at secunet.com>
    Reviewed-on: http://review.coreboot.org/3391
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Tested-by: build bot (Jenkins)
    Reviewed-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>


See http://review.coreboot.org/3391 for details.

-gerrit



More information about the coreboot-gerrit mailing list